codechecker issues

Author: bluetom

classes/local/manager/trigger_manager.php

@@ -28,6 +28,8 @@
 use tool_lifecycle\local\entity\trigger_subplugin;
 use tool_lifecycle\settings_type;
 
+defined('MOODLE_INTERNAL') || die();
+
 require_once(__DIR__ . '/../../../locallib.php');
 
 /**

trigger/semindependent/lib.php

@@ -30,6 +30,7 @@
 use tool_lifecycle\settings_type;
 
 defined('MOODLE_INTERNAL') || die();
+
 require_once(__DIR__ . '/../lib.php');
 require_once(__DIR__ . '/../../lib.php');
 require_once(__DIR__ . '/../../locallib.php');
@@ -66,7 +67,7 @@ public function get_course_recordset_where($triggerid) {
         if ($nosemester) {
             require_once($CFG->dirroot.'/customfield/field/semester/locallib.php');
             $termindependentintvalue = CUSTOMFIELD_SEMESTER_INTERNAL_TERMINDEPENDENT;
-            $where = " NOT EXISTS (SELECT 1 FROM {customfield_data} AS cfd WHERE cfd.fieldid = :customfield AND
+            $where = " NOT EXISTS (SELECT 1 FROM {customfield_data} cfd WHERE cfd.fieldid = :customfield AND
                     cfd.instanceid = c.id AND cfd.intvalue <> :termindependentintvalue) ";
             if ($exclude) {
                 $where = " NOT ($where) ";

workflowoverview.php

@@ -408,7 +408,7 @@
                     "wf" => $workflowid,
                     "trigger" => $triggerid,
                     "showtablesql" => "1",
-                    "showdetails" => "1"
+                    "showdetails" => "1",
                 ]),
                 "XXYYZZ   ", ["class" => "text-muted fs-6 text-decoration-none"]));
     }