workflowoverview: show also 0 courses in exclude trigger. Make instancenames in supplugin form of active workflows static

Author: bluetom

classes/local/form/form_step_instance.php

@@ -111,16 +111,22 @@ public function definition() {
         $mform->addElement('header', 'step_settings_header', get_string('step_settings_header', 'tool_lifecycle'));
 
         $elementname = 'instancename';
-        $mform->addElement('text', $elementname, get_string('step_instancename', 'tool_lifecycle'));
-        $mform->addHelpButton($elementname, 'step_instancename', 'tool_lifecycle');
-        $mform->setType($elementname, PARAM_TEXT);
-        $mform->addRule($elementname, get_string('maximumchars', '', 100), 'maxlength', 100, 'client');
-        $mform->addRule($elementname, null, 'required');
+        if ($this->workflowid && !workflow_manager::is_editable($this->workflowid)) {
+            $mform->addElement('static', $elementname, get_string('step_instancename', 'tool_lifecycle'));
+            $mform->setType($elementname, PARAM_TEXT);
+        } else {
+            $mform->addElement('text', $elementname, get_string('step_instancename', 'tool_lifecycle'));
+            $mform->addHelpButton($elementname, 'step_instancename', 'tool_lifecycle');
+            $mform->setType($elementname, PARAM_TEXT);
+            $mform->addRule($elementname, get_string('maximumchars', '', 100), 'maxlength', 100, 'client');
+            $mform->addRule($elementname, null, 'required');
+        }
 
         $elementname = 'subpluginnamestatic';
         $mform->addElement('static', $elementname, get_string('step_subpluginname', 'tool_lifecycle'));
         $mform->addHelpButton($elementname, 'step_subpluginname', 'tool_lifecycle');
         $mform->setType($elementname, PARAM_TEXT);
+
         $elementname = 'subpluginname';
         $mform->addElement('hidden', $elementname);
         $mform->setType($elementname, PARAM_TEXT);

classes/local/form/form_trigger_instance.php

@@ -118,11 +118,17 @@ public function definition() {
         $mform->addElement('header', 'trigger_settings_header', get_string('trigger_settings_header', 'tool_lifecycle'));
 
         $elementname = 'instancename';
-        $mform->addElement('text', $elementname, get_string('trigger_instancename', 'tool_lifecycle'));
-        $mform->addHelpButton($elementname, 'trigger_instancename', 'tool_lifecycle');
-        $mform->setType($elementname, PARAM_TEXT);
-        $mform->addRule($elementname, get_string('maximumchars', '', 100), 'maxlength', 100, 'client');
-        $mform->addRule($elementname, null, 'required');
+        if ($this->workflowid && !workflow_manager::is_editable($this->workflowid)) {
+            $mform->addElement('static', $elementname,
+                get_string('trigger_instancename', 'tool_lifecycle'));
+            $mform->setType($elementname, PARAM_TEXT);
+        } else {
+            $mform->addElement('text', $elementname, get_string('trigger_instancename', 'tool_lifecycle'));
+            $mform->addHelpButton($elementname, 'trigger_instancename', 'tool_lifecycle');
+            $mform->setType($elementname, PARAM_TEXT);
+            $mform->addRule($elementname, get_string('maximumchars', '', 100), 'maxlength', 100, 'client');
+            $mform->addRule($elementname, null, 'required');
+        }
 
         $elementname = 'subpluginnamestatic';
         $mform->addElement('static', $elementname,

styles.css

@@ -32,7 +32,7 @@ span.tool_lifecycle-hint {
     text-align: center;
     border: 1px solid #aaa;
     border-radius: 8px;
-    min-width: 220px;
+    min-width: 260px;
     background-color: white;
 }
 
@@ -47,6 +47,7 @@ span.tool_lifecycle-hint {
 
 #lifecycle-workflow-details .workflow-trigger {
     max-width: 300px;
+    min-width: 260px;
     margin: 8px;
 }
 

templates/overview_trigger.mustache

@@ -67,6 +67,13 @@
                             </span>
                             </a>
                         {{/excludedcourses}}
+                        {{^excludedcourses}}
+                            {{#exclude}}
+                                <span class="btn btn-outline-danger">
+                                    0
+                                </span>
+                            {{/exclude}}
+                        {{/excludedcourses}}
                     {{/additionalinfo}}
                 {{/automatic}}
                 {{^automatic}}

workflowoverview.php

@@ -38,6 +38,7 @@
 use tool_lifecycle\local\manager\delayed_courses_manager;
 use tool_lifecycle\local\manager\lib_manager;
 use tool_lifecycle\local\manager\process_manager;
+use tool_lifecycle\local\manager\settings_manager;
 use tool_lifecycle\local\manager\step_manager;
 use tool_lifecycle\local\manager\trigger_manager;
 use tool_lifecycle\local\manager\workflow_manager;
@@ -267,6 +268,8 @@
                 $trigger->classfires = "border-danger";
                 $trigger->additionalinfo = $amounts[$trigger->sortindex]->additionalinfo ?? "-";
             } else {
+                $settings = settings_manager::get_settings($trigger->id, settings_type::TRIGGER);
+                $trigger->exclude = $settings['exclude'] ?? false;
                 if ($response != trigger_response::triggertime()) {
                     if ($amounts[$trigger->sortindex]->triggered) {
                         $trigger->classfires = "border-success";