improve performance of get_count_of_courses_to_trigger_for_workflow

Author: bluetom

classes/local/manager/delayed_courses_manager.php

@@ -131,12 +131,8 @@ public static function set_course_delayed($courseid, $duration, $delaytype = 0)
      */
     public static function get_course_delayed($courseid) {
         global $DB;
-        $record = $DB->get_record('tool_lifecycle_delayed', ['courseid' => $courseid]);
-        if ($record) {
-            return $record->delayeduntil;
-        } else {
-            return null;
-        }
+        $delayeduntil = $DB->get_field('tool_lifecycle_delayed', 'delayeduntil', ['courseid' => $courseid]);
+        return $delayeduntil ?? 0;
     }
 
     /**
@@ -148,12 +144,9 @@ public static function get_course_delayed($courseid) {
      */
     public static function get_course_delayed_workflow($courseid, $workflowid) {
         global $DB;
-        $record = $DB->get_record('tool_lifecycle_delayed_workf', ['courseid' => $courseid, 'workflowid' => $workflowid]);
-        if ($record) {
-            return $record->delayeduntil;
-        } else {
-            return null;
-        }
+        $delayeduntil = $DB->get_field('tool_lifecycle_delayed_workf', 'delayeduntil',
+            ['courseid' => $courseid, 'workflowid' => $workflowid]);
+        return $delayeduntil ?? 0;
     }
 
     /**

classes/local/manager/process_manager.php

@@ -236,24 +236,10 @@ public static function get_process_by_course_id($courseid) {
     public static function has_other_process($courseid, $workflowid) {
         global $DB;
 
-        $ret = 0;
-        $records = $DB->get_records('tool_lifecycle_process', ['courseid' => $courseid], '', 'id, workflowid');
-        foreach ($records as $record) {
-            if ($record->workflowid != $workflowid) {
-                $ret = 2;
-                break;
-            }
-            $ret = 1;
-        }
-        if ($ret != 2) {
-            $records = $DB->get_records('tool_lifecycle_proc_error', ['courseid' => $courseid], '', 'id, workflowid');
-            foreach ($records as $record) {
-                if ($record->workflowid != $workflowid) {
-                    $ret = 2;
-                    break;
-                }
-                $ret = 1;
-            }
+        if (!$ret = $DB->record_exists_select('tool_lifecycle_process',
+            "courseid = $courseid and workflowid <> $workflowid")) {
+            $ret = $DB->record_exists_select('tool_lifecycle_proc_error',
+                "courseid = $courseid and workflowid <> $workflowid");
         }
         return $ret;
     }

classes/processor.php

@@ -312,8 +312,8 @@ public function get_count_of_courses_to_trigger_for_workflow($workflow) {
 
         while ($recordset->valid()) {
             $course = $recordset->current();
-            $delaytime = max(delayed_courses_manager::get_course_delayed($course->id) ?? 0,
-                delayed_courses_manager::get_course_delayed_workflow($course->id, $workflow->id) ?? 0);
+            $delaytime = max(delayed_courses_manager::get_course_delayed($course->id),
+                delayed_courses_manager::get_course_delayed_workflow($course->id, $workflow->id));
             $coursedelayed = $delaytime > time();
             if ($hasother = process_manager::has_other_process($course->id, $workflow->id)) {
                 if ($hasother == OTHERWORKFLOW) {