step link in wf overview only if courses > 0

Author: bluetom

styles.css

@@ -100,7 +100,7 @@ span.tool_lifecycle-hint {
 #lifecycle-workflow-details .courses-table {
     flex: 40% 1 1;
     border: 1px solid #bbb;
-    border-right: none;
+    margin-right: 2em;
 }
 
 #lifecycle-workflow-details .bar {

templates/workflowoverview.mustache

@@ -129,9 +129,14 @@
                     </div>
                 </div>
                 <div class="wf-content">
-                    <a href="{{nosteplink}}&step={{id}}">{{icon}}{{name}}
-                    {{#str}} courses {{/str}}: {{numberofcourses}}
-                    </a>
+                    {{#numberofcourses}}
+                        <a href="{{nosteplink}}&step={{id}}">{{icon}}{{name}}
+                        {{#str}} courses {{/str}}: {{numberofcourses}}
+                        </a>
+                    {{/numberofcourses}}
+                    {{^numberofcourses}}
+                        {{#str}} courses {{/str}}: {{numberofcourses}}
+                    {{/numberofcourses}}
                 </div>
             </div>
         {{/steps}}

workflowoverview.php

@@ -117,10 +117,12 @@
 
 $showcoursecounts = get_config('tool_lifecycle', 'showcoursecounts');
 if ($showcoursecounts) {
-    // On moodle instances with many courses the following call can be fatal, because each trigger
-    // check function will be called for every single course of the instance to determine how many
-    // courses will be triggered by the workflow/the specific trigger. This count is only being
-    // used to show the admin how many courses will be triggered, it has no functional aspect.
+    /*
+        On moodle instances with many courses the following call can be fatal, because each trigger
+        check function will be called for every single course of the instance to determine how many
+        courses will be triggered by the workflow/the specific trigger. This count is only being
+        used to show the admin how many courses will be triggered, it has no functional aspect.
+    */
     $amounts = (new \tool_lifecycle\processor())->get_count_of_courses_to_trigger_for_workflow($workflow->id);
     $displaytotaltriggered = !empty($triggers);
 }