manual trigger uninstall by uninstall buttons in trigger list

Author: bluetom

activeprocesses.php

@@ -74,8 +74,6 @@
 $id = 'activeworkflows';
 $renderer->tabs($tabrow, $id);
 
-$renderer = $PAGE->get_renderer('tool_lifecycle');
-
 $table = new active_processes_table('tool_lifecycle_active_processes', $data);
 
 $mform->display();

classes/plugininfo/lifecycletrigger.php

@@ -49,11 +49,14 @@ public function is_uninstall_allowed() {
         if ($this->is_standard()) {
             return false;
         }
-        // Only allow uninstall, if no active workflow for the trigger is present.
-        $triggers = trigger_manager::get_instances($this->name);
-        foreach ($triggers as $trigger) {
-            if (workflow_manager::is_active($trigger->workflowid)) {
-                return false;
+        $lib = lib_manager::get_trigger_lib($this->name);
+        if ($lib->has_multiple_instances()) {
+            // Only allow uninstall, if no active workflow for the trigger is present.
+            $triggers = trigger_manager::get_instances($this->name);
+            foreach ($triggers as $trigger) {
+                if (workflow_manager::is_active($trigger->workflowid)) {
+                    return false;
+                }
             }
         }
         return true;

remove.php

@@ -75,9 +75,19 @@
         $settings->add(new admin_setting_heading('lifecycletriggerheader',
             get_string('triggers_installed', 'tool_lifecycle'), ''));
         foreach ($triggers as $trigger => $path) {
+            $uninstall = '';
+            if ($trigger == 'sitecourse') {
+                $link = \html_writer::link($CFG->wwwroot . '/admin/plugins.php?uninstall=lifecycletrigger_sitecourse',
+                    'Uninstall', ['target' => '_blank', 'class' => 'btn btn-primary']);
+                $uninstall = html_writer::span(' Depracated! Please '.$link, 'text-danger');
+            } else if ($trigger == 'delayedcourses') {
+                $link = \html_writer::link($CFG->wwwroot . '/admin/plugins.php?uninstall=lifecycletrigger_delayedcourses',
+                    'Uninstall', ['target' => '_blank', 'class' => 'btn btn-primary']);
+                $uninstall = html_writer::span(' Depracated! Please '.$link, 'text-danger');
+            }
             $settings->add(new admin_setting_description('lifecycletriggersetting_'.$trigger,
                 get_string('pluginname', 'lifecycletrigger_' . $trigger),
-                get_string('plugindescription', 'lifecycletrigger_' . $trigger)));
+                get_string('plugindescription', 'lifecycletrigger_' . $trigger).$uninstall));
         }
     } else {
         $settings->add(new admin_setting_heading('adminsettings_notriggers',