codechecker issues customfielddelay

Author: bluetom

trigger/customfielddelay/classes/privacy/provider.php

@@ -33,7 +33,7 @@ class provider implements null_provider {
      *
      * @return string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

trigger/customfielddelay/lib.php

@@ -56,17 +56,14 @@ public function get_course_recordset_where($triggerid) {
         global $DB;
         $delay = settings_manager::get_settings($triggerid, settings_type::TRIGGER)['delay'];
         $fieldname = settings_manager::get_settings($triggerid, settings_type::TRIGGER)['customfield'];
-        if (!($field = $DB->get_record('customfield_field', array('shortname' => $fieldname, 'type' => 'date')))) {
+        if (!($field = $DB->get_record('customfield_field', ['shortname' => $fieldname, 'type' => 'date']))) {
             throw new \moodle_exception("missingfield");
         }
         $where = "{course}.id in (select cxt.instanceid from {context} cxt join {customfield_data} d " .
                     "ON d.contextid = cxt.id AND cxt.contextlevel=" . CONTEXT_COURSE . " " .
                     "WHERE d.fieldid = :customfieldid AND d.intvalue > 0 AND d.intvalue < :customfielddelay)";
-        $params = array(
-            "customfielddelay" => time() - $delay,
-            "customfieldid" => $field->id,
-        );
-        return array($where, $params);
+        $params = ["customfielddelay" => time() - $delay, "customfieldid" => $field->id];
+        return [$where, $params];
     }
 
     /**
@@ -82,10 +79,7 @@ public function get_subpluginname() {
      * @return instance_setting[] containing settings keys and PARAM_TYPES
      */
     public function instance_settings() {
-        return array(
-            new instance_setting('delay', PARAM_INT),
-            new instance_setting('customfield', PARAM_TEXT),
-        );
+        return [new instance_setting('delay', PARAM_INT), new instance_setting('customfield', PARAM_TEXT)];
     }
 
     /**
@@ -98,8 +92,8 @@ public function extend_add_instance_form_definition($mform) {
         global $DB;
         $mform->addElement('duration', 'delay', get_string('delay', 'lifecycletrigger_customfielddelay'));
         $mform->addHelpButton('delay', 'delay', 'lifecycletrigger_customfielddelay');
-        $fields = $DB->get_records('customfield_field', array('type' => 'date'));
-        $choices = array();
+        $fields = $DB->get_records('customfield_field', ['type' => 'date']);
+        $choices = [];
         foreach ($fields as $field) {
             $choices[$field->shortname] = $field->name;
         }

trigger/customfielddelay/tests/trigger_test.php

@@ -40,7 +40,7 @@
  * @copyright  2020 Tobias Reischmann WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class trigger_test extends \advanced_testcase {
+final class trigger_test extends \advanced_testcase {
 
     /** @var $triggerinstance trigger_subplugin Instance of the trigger. */
     private $triggerinstance;
@@ -58,7 +58,7 @@ class trigger_test extends \advanced_testcase {
      * @return void
      * @throws \moodle_exception
      */
-    public function setUp() : void {
+    public function setUp(): void {
         $this->resetAfterTest(true);
         $this->setAdminUser();
 
@@ -82,7 +82,7 @@ public function setUp() : void {
      * @throws \coding_exception
      * @throws \dml_exception
      */
-    public function test_young_course() {
+    public function test_young_course(): void {
         $customfieldvalue = ['shortname' => 'test', 'value' => time() + 1000000];
         $course = $this->getDataGenerator()->create_course(['customfields' => [$customfieldvalue]]);
 
@@ -106,7 +106,7 @@ public function test_young_course() {
      * @throws \coding_exception
      * @throws \dml_exception
      */
-    public function test_young_course_with_second_customcourse_field() {
+    public function test_young_course_with_second_customcourse_field(): void {
 
         // Add additional course field.
         $customfield = ['shortname' => 'test2', 'name' => 'Custom field2', 'type' => 'date',
@@ -136,7 +136,7 @@ public function test_young_course_with_second_customcourse_field() {
      * @throws \coding_exception
      * @throws \dml_exception
      */
-    public function test_old_course() {
+    public function test_old_course(): void {
 
         $customfieldvalue = ['shortname' => 'test', 'value' => time() - 1000000];
         $course = $this->getDataGenerator()->create_course(['customfields' => [$customfieldvalue]]);

trigger/customfielddelay/version.php

@@ -31,4 +31,4 @@
 $plugin->component = 'lifecycletrigger_customfielddelay';
 $plugin->release   = 'v4.5-r1';
 $plugin->maturity = MATURITY_STABLE;
-$plugin->dependencies = ['customfield_semester' => 2020041304,];
+$plugin->dependencies = ['customfield_semester' => 2020041304];