add tests

Author: lecousin

core.loaders/maven/src/main/java/net/lecousin/core/loaders/maven/MavenPOM.java

@@ -694,19 +694,20 @@ private Repository readRepository(XMLStreamReader xml) throws MavenPOMException,
 				} else if (xml.event.text.equals("url")) {
 					repo.url = xml.readInnerText().trim().asString();
 				} else if (xml.event.text.equals("releases")) {
-					readRepositoryType(xml, ctx, repo, true);
+					readRepositoryType(xml, repo, true);
 				} else if (xml.event.text.equals("snapshots")) {
-					readRepositoryType(xml, ctx, repo, false);
+					readRepositoryType(xml, repo, false);
 				} else {
 					xml.closeElement();
 				}
 			} while (true);
 			return repo;
 		}
 
-		private void readRepositoryType(XMLStreamReader xml, ElementContext ctx, Repository repo, boolean isReleases)
+		private void readRepositoryType(XMLStreamReader xml, Repository repo, boolean isReleases)
 		throws XMLException, MavenPOMException, IOException {
 			if (xml.event.isClosed) return;
+			ElementContext ctx = xml.event.context.getFirst();
 			do {
 				if (!xml.nextInnerElement(ctx)) {
 					if (!Type.END_ELEMENT.equals(xml.event.type))

core.loaders/maven/src/test/java/net/lecousin/core/loaders/maven/tests/TestLocalRepository.java

@@ -187,6 +187,7 @@ public void testMyPOM() throws Exception {
 		AsyncSupplier<? extends LibraryDescriptor, LibraryManagementException> load2 = pomLoader.loadProject(new File("."), Task.PRIORITY_NORMAL);
 		LibraryDescriptor lib = load2.blockResult(30000);
 		Assert.assertEquals(lib.getArtifactId(), "maven");
+		lib.getDependencies();
 	}
 
 	@Test
@@ -208,6 +209,7 @@ public void testPOMWithOutputDirectory() throws Exception {
 			File classes = pom.getClasses().blockResult(30000);
 			Assert.assertNotNull(classes);
 			Assert.assertEquals(new File("./target/test-out").getAbsolutePath(), classes.getAbsolutePath());
+			pom.getDependencies();
 		} finally {
 			outFile.delete();
 		}
@@ -284,6 +286,7 @@ private void testError(String errorName) throws IOException, CancelException, UR
 	public void testErrors() throws Exception {
 		testError("invalid-root");
 		testError("invalid-xml");
+		testError("invalid-xml2");
 		testError("empty");
 	}
 

core.loaders/maven/src/test/resources/test-maven/error/test-invalid-xml.pom.xml

@@ -8,5 +8,4 @@
 	<packaging>bundle</packaging>
 
 	<build>
-		<outputDirectory>target/test-out</outputDirectory>
-</project>
+		<outputDirectory>target/test-out</outputDirectory>

core.loaders/maven/src/test/resources/test-maven/error/test-invalid-xml2.pom.xml

@@ -0,0 +1,15 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+	<groupId>test</groupId>
+	<artifactId>maven</artifactId>
+	<version>1</version>
+	<packaging>bundle</packaging>
+	
+	<error / error>
+
+	<build>
+		<outputDirectory>target/test-out</outputDirectory>
+	</build>
+</project>

core.loaders/maven/src/test/resources/test-maven/test-additional-fields.pom.xml

@@ -46,9 +46,21 @@
 					<unknown/>
 				</property>
 				<file>
+					<missing>hello</missing>
 					<unknown/>
 				</file>
+				<activeByDefault>false</activeByDefault>
 			</activation>
+			<repositories>
+				<unknown/>
+				<repository>
+					<unknown/>
+					<snapshots>
+						<enabled>false</enabled>
+						<unknown/>
+					</snapshots>
+				</repository>
+			</repositories>
 		</profile>
 	</profiles>
 

core.loaders/maven/src/test/resources/test-maven/test-output-dir.pom.xml

@@ -6,6 +6,23 @@
 	<artifactId>maven</artifactId>
 	<version>1</version>
 	<packaging>bundle</packaging>
+	
+	<parent/>
+
+	<dependencies>
+		<dependency>
+			<groupId>junit</groupId>
+			<artifactId>junit</artifactId>
+			<version>4.12</version>
+			<scope>compile</scope>
+			<exclusions>
+				<exclusion>
+					<groupId>*</groupId>
+					<artifactId>*</artifactId>
+				</exclusion>
+			</exclusions>
+		</dependency>
+	</dependencies>
 
 	<build>
 		<outputDirectory>target/test-out</outputDirectory>

net.lecousin.core/src/main/java/net/lecousin/framework/util/UnprotectedStringBuffer.java

@@ -969,8 +969,9 @@ public int readSync(char[] buf, int offset, int length) {
 					return 1;
 				if (strings == null) return 1;
 				done = 1;
-			} else if (strings == null)
+			} else if (strings == null) {
 				return -1;
+			}
 			do {
 				while (buffer <= lastUsed && bufferIndex == strings[buffer].length()) {
 					buffer++;

net.lecousin.core/src/test/java/net/lecousin/framework/core/tests/event/TestAsyncEvent.java

@@ -32,4 +32,12 @@ public void test() {
 		Assert.assertFalse(sp.isDone());
 	}
 
+	@Test
+	public void testListenerError() {
+		AsyncEvent e = new AsyncEvent();
+		Runnable listener = () -> { throw new RuntimeException("a test"); };
+		e.addListener(listener);
+		e.fire();
+	}
+	
 }

net.lecousin.core/src/test/java/net/lecousin/framework/core/tests/event/TestEvent.java

@@ -118,4 +118,14 @@ public void test() {
 		Assert.assertEquals(30, val2.get());
 	}
 
+	@Test
+	public void testListenerError() {
+		Event<Integer> e = new Event<>();
+		Runnable listener1 = () -> { throw new RuntimeException("a test"); };
+		Consumer<Integer> listener2 = ev -> { throw new RuntimeException("a test"); };
+		e.addListener(listener1);
+		e.addListener(listener2);
+		e.fire(Integer.valueOf(10));
+	}
+	
 }

net.lecousin.core/src/test/java/net/lecousin/framework/core/tests/math/TestFragmentedRangeBigInteger.java

@@ -4,13 +4,13 @@
 import java.util.Arrays;
 import java.util.List;
 
-import org.junit.Assert;
-import org.junit.Test;
-
 import net.lecousin.framework.core.test.LCCoreAbstractTest;
 import net.lecousin.framework.math.FragmentedRangeBigInteger;
 import net.lecousin.framework.math.RangeBigInteger;
 
+import org.junit.Assert;
+import org.junit.Test;
+
 public class TestFragmentedRangeBigInteger extends LCCoreAbstractTest {
 
 	@Test
@@ -93,6 +93,10 @@ public void test() throws Exception {
 		Assert.assertFalse(f.containsRange(BigInteger.valueOf(300), BigInteger.valueOf(400)));
 		Assert.assertTrue(f.containsRange(BigInteger.valueOf(500), BigInteger.valueOf(120)));
 
+		Assert.assertTrue(f.containsOneValueIn(Arrays.asList(new RangeBigInteger(BigInteger.valueOf(101), BigInteger.valueOf(150)), new RangeBigInteger(BigInteger.valueOf(50), BigInteger.valueOf(70)))));
+		Assert.assertTrue(f.containsOneValueIn(Arrays.asList(new RangeBigInteger(BigInteger.valueOf(50), BigInteger.valueOf(70)), new RangeBigInteger(BigInteger.valueOf(101), BigInteger.valueOf(150)))));
+		Assert.assertFalse(f.containsOneValueIn(Arrays.asList(new RangeBigInteger(BigInteger.valueOf(50), BigInteger.valueOf(70)), new RangeBigInteger(BigInteger.valueOf(300), BigInteger.valueOf(400)))));
+		
 		// 9-31, 100-155, 175-180, 190-250
 		f.addRange(BigInteger.valueOf(151), BigInteger.valueOf(155));
 		Assert.assertEquals(4, f.size());