Skip to content

Commit 0d3e93e

Browse files
efahlhauke
authored andcommitted
mediatek: filogic: fix supported_devices list for gl-mt2500
The SUPPORTED_DEVICES sets for both Maxlinear (v1) and Airoha (v2) devices were identical, so sysupgrade was unable to detect when an incorrect image was being installed. This caused "soft bricking" of devices when a v1 image was installed on a v2 device, and vice versa. Fix this by making the supported_devices distinct for each device version, by renaming the devices with a version-specific name. This is reflected in the file name and the image metadata. Fixes: openwrt/openwrt#20566 Fixes: openwrt/asu#1525 Signed-off-by: Eric Fahlgren <[email protected]> Link: openwrt/openwrt#20632 Signed-off-by: Hauke Mehrtens <[email protected]> (cherry picked from commit b71f466)
1 parent 234b367 commit 0d3e93e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

target/linux/mediatek/image/filogic.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,7 +1306,7 @@ define Device/glinet_gl-mt2500
13061306
DEVICE_DTS_DIR := ../dts
13071307
DEVICE_DTS_LOADADDR := 0x47000000
13081308
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3
1309-
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500-airoha
1309+
SUPPORTED_DEVICES += glinet,mt2500-emmc
13101310
IMAGES := sysupgrade.bin factory.bin
13111311
IMAGE/factory.bin := append-kernel | pad-to 32M | append-rootfs
13121312
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
@@ -1324,7 +1324,7 @@ define Device/glinet_gl-mt2500-airoha
13241324
DEVICE_DTS_DIR := ../dts
13251325
DEVICE_DTS_LOADADDR := 0x47000000
13261326
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3 kmod-phy-airoha-en8811h airoha-en8811h-firmware
1327-
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500
1327+
SUPPORTED_DEVICES += glinet,mt2500-emmc
13281328
IMAGES := sysupgrade.bin
13291329
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
13301330
endef

0 commit comments

Comments
 (0)