Skip to content

Commit 1fdc4b1

Browse files
Lanchonrobimarko
authored andcommitted
ipq806x: tr4400v2: revert nesting of MTD partitions that bricks device
This reverts commit e1043a7, that attempts to nest partitions that overlap but are not nested. This causes the 'ubi' partition to be truncated, making rootfs inaccessible and bricking the device. Also, had this commit worked, it would have renumbered MTD partitions in a way that would have broken documented scripts for installation and update of main and recovery OSes, making backups, return to stock, etc, and broken user configurations that put the 'extra' partition to use. Signed-off-by: Rodrigo Balerdi <[email protected]> Link: openwrt/openwrt#16944 Signed-off-by: Robert Marko <[email protected]> (cherry picked from commit 0e59eaa)
1 parent e39f5d4 commit 1fdc4b1

File tree

1 file changed

+35
-45
lines changed

1 file changed

+35
-45
lines changed

target/linux/ipq806x/files-6.6/arch/arm/boot/dts/qcom/qcom-ipq8065-tr4400-v2.dts

Lines changed: 35 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -207,15 +207,6 @@
207207
stock_partition@1340000 {
208208
label = "stock_rootfs";
209209
reg = <0x1340000 0x4000000>;
210-
211-
compatible = "fixed-partitions";
212-
#address-cells = <1>;
213-
#size-cells = <1>;
214-
215-
partition@0 {
216-
label = "extra";
217-
reg = <0x0 0x4000000>;
218-
};
219210
};
220211
partition@5340000 {
221212
label = "0:BOOTCONFIG";
@@ -265,42 +256,6 @@
265256
stock_partition@6400000 {
266257
label = "stock_rootfs_1";
267258
reg = <0x6400000 0x4000000>;
268-
269-
compatible = "fixed-partitions";
270-
#address-cells = <1>;
271-
#size-cells = <1>;
272-
273-
partition@0 {
274-
label = "fw_env";
275-
reg = <0x0 0x100000>;
276-
277-
nvmem-layout {
278-
compatible = "fixed-layout";
279-
#address-cells = <1>;
280-
#size-cells = <1>;
281-
282-
macaddr_fw_env_0: macaddr@0 {
283-
reg = <0x00 0x6>;
284-
};
285-
macaddr_fw_env_6: macaddr@6 {
286-
reg = <0x06 0x6>;
287-
};
288-
macaddr_fw_env_c: macaddr@c {
289-
reg = <0x0c 0x6>;
290-
};
291-
macaddr_fw_env_12: macaddr@12 {
292-
reg = <0x12 0x6>;
293-
};
294-
macaddr_fw_env_18: macaddr@18 {
295-
reg = <0x18 0x6>;
296-
};
297-
};
298-
};
299-
300-
partition@100000 {
301-
label = "ubi";
302-
reg = <0x100000 0x9b00000>;
303-
};
304259
};
305260
stock_partition@a400000 {
306261
label = "stock_fw_env";
@@ -318,6 +273,41 @@
318273
label = "stock_scfgmgr";
319274
reg = <0xaf00000 0x0100000>;
320275
};
276+
277+
partition@6400000 {
278+
label = "fw_env";
279+
reg = <0x6400000 0x0100000>;
280+
281+
nvmem-layout {
282+
compatible = "fixed-layout";
283+
#address-cells = <1>;
284+
#size-cells = <1>;
285+
286+
macaddr_fw_env_0: macaddr@0 {
287+
reg = <0x00 0x6>;
288+
};
289+
macaddr_fw_env_6: macaddr@6 {
290+
reg = <0x06 0x6>;
291+
};
292+
macaddr_fw_env_c: macaddr@c {
293+
reg = <0x0c 0x6>;
294+
};
295+
macaddr_fw_env_12: macaddr@12 {
296+
reg = <0x12 0x6>;
297+
};
298+
macaddr_fw_env_18: macaddr@18 {
299+
reg = <0x18 0x6>;
300+
};
301+
};
302+
};
303+
partition@6500000 {
304+
label = "ubi";
305+
reg = <0x6500000 0x9b00000>;
306+
};
307+
partition@1340000 {
308+
label = "extra";
309+
reg = <0x1340000 0x4000000>;
310+
};
321311
};
322312
};
323313
};

0 commit comments

Comments
 (0)