Skip to content

Commit 703e7d2

Browse files
nwfrobimarko
authored andcommitted
cmake: use RelWithDebInfo, not Debug, with CONFIG_DEBUG
Given the description of the configuration option at its definition in target/sdk/files/Config.in ("Compile packages with debugging info" and "Adds -g3 to the CFLAGS", the more appropriate CMAKE build type is `RelWithDebInfo` rather than `Debug`. Signed-off-by: Nathaniel Wesley Filardo <[email protected]> Link: openwrt/openwrt#18709 Signed-off-by: Robert Marko <[email protected]>
1 parent 53054fe commit 703e7d2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/cmake.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ define Build/Configure/Default
9797
-DCMAKE_SYSTEM_NAME=Linux \
9898
-DCMAKE_SYSTEM_VERSION=1 \
9999
-DCMAKE_SYSTEM_PROCESSOR=$(ARCH) \
100-
-DCMAKE_BUILD_TYPE=$(if $(CONFIG_DEBUG),Debug,Release) \
100+
-DCMAKE_BUILD_TYPE=$(if $(CONFIG_DEBUG),RelWithDebInfo,Release) \
101101
-DCMAKE_C_FLAGS_RELEASE="-DNDEBUG" \
102102
-DCMAKE_CXX_FLAGS_RELEASE="-DNDEBUG" \
103103
-DCMAKE_C_COMPILER_LAUNCHER="$(CMAKE_C_COMPILER_LAUNCHER)" \

0 commit comments

Comments
 (0)