Skip to content

Commit 8026644

Browse files
jonasjelonekrobimarko
authored andcommitted
realtek: fix SFP GPIOs for XikeStor SKS8310-8X
Fix the GPIO assignment of RX-LOS and TX-DISABLE for all SFP ports. Both were actually swapped when adding support for the device. Apparently, this didn't cause any issues. Fixes: 62d50fb Signed-off-by: Jonas Jelonek <[email protected]> Link: openwrt/openwrt#20532 Signed-off-by: Robert Marko <[email protected]>
1 parent 8103b79 commit 8026644

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

target/linux/realtek/dts/rtl9303_xikestor_sks8310-8x.dts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,79 +56,79 @@
5656
sfp0: sfp-p1 {
5757
compatible = "sff,sfp";
5858
i2c-bus = <&i2c0>;
59-
los-gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
59+
los-gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
6060
mod-def0-gpio = <&gpio1 1 GPIO_ACTIVE_LOW>;
61-
tx-disable-gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
61+
tx-disable-gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
6262
maximum-power-milliwatt = <2900>;
6363
#thermal-sensor-cells = <0>;
6464
};
6565

6666
sfp1: sfp-p2 {
6767
compatible = "sff,sfp";
6868
i2c-bus = <&i2c1>;
69-
los-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
69+
los-gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
7070
mod-def0-gpio = <&gpio1 4 GPIO_ACTIVE_LOW>;
71-
tx-disable-gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
71+
tx-disable-gpio = <&gpio1 3 GPIO_ACTIVE_HIGH>;
7272
maximum-power-milliwatt = <1500>;
7373
#thermal-sensor-cells = <0>;
7474
};
7575

7676
sfp2: sfp-p3 {
7777
compatible = "sff,sfp";
7878
i2c-bus = <&i2c2>;
79-
los-gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>;
79+
los-gpio = <&gpio1 8 GPIO_ACTIVE_HIGH>;
8080
mod-def0-gpio = <&gpio1 7 GPIO_ACTIVE_LOW>;
81-
tx-disable-gpio = <&gpio1 8 GPIO_ACTIVE_HIGH>;
81+
tx-disable-gpio = <&gpio1 6 GPIO_ACTIVE_HIGH>;
8282
maximum-power-milliwatt = <1500>;
8383
#thermal-sensor-cells = <0>;
8484
};
8585

8686
sfp3: sfp-p4 {
8787
compatible = "sff,sfp";
8888
i2c-bus = <&i2c3>;
89-
los-gpio = <&gpio1 9 GPIO_ACTIVE_HIGH>;
89+
los-gpio = <&gpio1 11 GPIO_ACTIVE_HIGH>;
9090
mod-def0-gpio = <&gpio1 10 GPIO_ACTIVE_LOW>;
91-
tx-disable-gpio = <&gpio1 11 GPIO_ACTIVE_HIGH>;
91+
tx-disable-gpio = <&gpio1 9 GPIO_ACTIVE_HIGH>;
9292
maximum-power-milliwatt = <2000>;
9393
#thermal-sensor-cells = <0>;
9494
};
9595

9696
sfp4: sfp-p5 {
9797
compatible = "sff,sfp";
9898
i2c-bus = <&i2c4>;
99-
los-gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>;
99+
los-gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>;
100100
mod-def0-gpio = <&gpio1 13 GPIO_ACTIVE_LOW>;
101-
tx-disable-gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>;
101+
tx-disable-gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>;
102102
maximum-power-milliwatt = <2000>;
103103
#thermal-sensor-cells = <0>;
104104
};
105105

106106
sfp5: sfp-p6 {
107107
compatible = "sff,sfp";
108108
i2c-bus = <&i2c5>;
109-
los-gpio = <&gpio1 21 GPIO_ACTIVE_HIGH>;
109+
los-gpio = <&gpio1 23 GPIO_ACTIVE_HIGH>;
110110
mod-def0-gpio = <&gpio1 22 GPIO_ACTIVE_LOW>;
111-
tx-disable-gpio = <&gpio1 23 GPIO_ACTIVE_HIGH>;
111+
tx-disable-gpio = <&gpio1 21 GPIO_ACTIVE_HIGH>;
112112
maximum-power-milliwatt = <1500>;
113113
#thermal-sensor-cells = <0>;
114114
};
115115

116116
sfp6: sfp-p7 {
117117
compatible = "sff,sfp";
118118
i2c-bus = <&i2c6>;
119-
los-gpio = <&gpio1 24 GPIO_ACTIVE_HIGH>;
119+
los-gpio = <&gpio1 26 GPIO_ACTIVE_HIGH>;
120120
mod-def0-gpio = <&gpio1 25 GPIO_ACTIVE_LOW>;
121-
tx-disable-gpio = <&gpio1 26 GPIO_ACTIVE_HIGH>;
121+
tx-disable-gpio = <&gpio1 24 GPIO_ACTIVE_HIGH>;
122122
maximum-power-milliwatt = <1500>;
123123
#thermal-sensor-cells = <0>;
124124
};
125125

126126
sfp7: sfp-p8 {
127127
compatible = "sff,sfp";
128128
i2c-bus = <&i2c7>;
129-
los-gpio = <&gpio1 27 GPIO_ACTIVE_HIGH>;
129+
los-gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
130130
mod-def0-gpio = <&gpio1 28 GPIO_ACTIVE_LOW>;
131-
tx-disable-gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
131+
tx-disable-gpio = <&gpio1 27 GPIO_ACTIVE_HIGH>;
132132
maximum-power-milliwatt = <2900>;
133133
#thermal-sensor-cells = <0>;
134134
};

0 commit comments

Comments
 (0)