Skip to content

Commit b2c0182

Browse files
j4cbohauke
authored andcommitted
realtek: rtl838x: fix lan9 and lan10 on Netgear GS110TUP
The GS110TUP's lan9 port is connected via a QSGMII PHY to SERDES 2, and therefore should use the SWITCH_PORT_SDS macro instead of SWITCH_PORT. This was missed in e956adf because the GS110TUP is not particularly well documented and the old code was confusing. lan10 is an SFP and doesn't have an onboard PHY, so also remove its associated PHY references and update it to match other devices' SFP ports. Fixes: openwrt/openwrt#21324 Signed-off-by: Jacob Potter <jacob@j4cbo.com> Link: openwrt/openwrt#21346 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
1 parent 96ad29a commit b2c0182

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

target/linux/realtek/dts/rtl8380_netgear_gs110tup-v1.dts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,24 +47,19 @@
4747

4848
&mdio_bus0 {
4949
EXTERNAL_PHY(16)
50-
EXTERNAL_PHY(24)
5150
};
5251

5352
&switch0 {
5453
ports {
55-
SWITCH_PORT(16, 9, qsgmii)
54+
SWITCH_PORT_SDS(16, 9, 2, qsgmii)
5655

57-
/* TODO: fixed link SFP is not right */
58-
port24: port@24 {
56+
port@24 {
5957
reg = <24>;
60-
label = SWITCH_PORT_LABEL(10);
58+
label = "lan10";
6159
pcs-handle = <&serdes4>;
62-
phy-handle = <&phy24>;
6360
phy-mode = "1000base-x";
64-
fixed-link {
65-
speed = <1000>;
66-
full-duplex;
67-
};
61+
managed = "in-band-status";
62+
/* i2c and gpios not yet identified */
6863
};
6964
};
7065
};

0 commit comments

Comments
 (0)