Skip to content

Commit b71f466

Browse files
efahlhauke
authored andcommitted
mediatek: filogic: fix supported_devices list for gl-mt2500
The SUPPORTED_DEVICES sets for both Maxlinear (v1) and Airoha (v2) devices were identical, so sysupgrade was unable to detect when an incorrect image was being installed. This caused "soft bricking" of devices when a v1 image was installed on a v2 device, and vice versa. Fix this by making the supported_devices distinct for each device version, by renaming the devices with a version-specific name. This is reflected in the file name and the image metadata. Fixes: openwrt/openwrt#20566 Fixes: openwrt/asu#1525 Signed-off-by: Eric Fahlgren <[email protected]> Link: openwrt/openwrt#20632 Signed-off-by: Hauke Mehrtens <[email protected]>
1 parent 3af16b2 commit b71f466

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

target/linux/mediatek/image/filogic.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1379,7 +1379,7 @@ define Device/glinet_gl-mt2500
13791379
DEVICE_DTS_DIR := ../dts
13801380
DEVICE_DTS_LOADADDR := 0x47000000
13811381
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3
1382-
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500-airoha
1382+
SUPPORTED_DEVICES += glinet,mt2500-emmc
13831383
IMAGES := sysupgrade.bin factory.bin
13841384
IMAGE/factory.bin := append-kernel | pad-to 32M | append-rootfs
13851385
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
@@ -1397,7 +1397,7 @@ define Device/glinet_gl-mt2500-airoha
13971397
DEVICE_DTS_DIR := ../dts
13981398
DEVICE_DTS_LOADADDR := 0x47000000
13991399
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3 kmod-phy-airoha-en8811h airoha-en8811h-firmware
1400-
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500
1400+
SUPPORTED_DEVICES += glinet,mt2500-emmc
14011401
IMAGES := sysupgrade.bin
14021402
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
14031403
endef

0 commit comments

Comments
 (0)