Skip to content

Commit b7c9051

Browse files
rany2hauke
authored andcommitted
wifi-scripts: ucode: allow sae_pwe to be modified for AP mode
Some Android devices have issues with H2E causing downgrades to PSK when using WPA2/3. With WPA3 it doesn't work reliably whatsoever. My Samsung A55/6 for example has the following behavior: daemon.info hostapd: lan5g: STA <redacted> IEEE 802.11: authenticated daemon.notice hostapd: SAE: <redacted> indicates support for SAE H2E, but did not use it daemon.info hostapd: lan2g: STA <redacted> IEEE 802.11: authenticated daemon.info hostapd: lan2g: STA <redacted> IEEE 802.11: associated (aid 1) daemon.notice hostapd: lan5g: Prune association for <redacted> daemon.notice hostapd: lan2g: AP-STA-CONNECTED <redacted> auth_alg=open daemon.info hostapd: lan2g: STA <redacted> RADIUS: starting accounting session 8234C696AAC1AE7D daemon.info hostapd: lan2g: STA <redacted> WPA: pairwise key handshake completed (RSN) daemon.notice hostapd: lan2g: EAPOL-4WAY-HS-COMPLETED <redacted> This is also brought up in the issue: openwrt/openwrt#9963 Ultimately this allows users to have the option to at the very least disable H2E. Unrelated: a minor cleanup was done so that ieee80211w uses set_default instead. There is no functional change on that front. Signed-off-by: Rany Hany <rany_hany@riseup.net> Link: openwrt/openwrt#22021 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit 70ba751)
1 parent 80ba5e4 commit b7c9051

File tree

1 file changed

+3
-4
lines changed
  • package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi

1 file changed

+3
-4
lines changed

package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,16 @@ function iface_auth_type(config) {
8686
config.ieee80211w = 2;
8787
config.sae_require_mfp = 1;
8888
if (!config.ppsk)
89-
config.sae_pwe = 2;
89+
set_default(config, 'sae_pwe', 2);
9090
}
9191

9292
if (config.auth_type in [ 'psk-sae', 'eap-eap2' ]) {
93-
if (!config.ieee80211w)
94-
config.ieee80211w = 1;
93+
set_default(config, 'ieee80211w', 1);
9594
if (config.rsn_override)
9695
config.rsn_override_mfp = 2;
9796
config.sae_require_mfp = 1;
9897
if (!config.ppsk)
99-
config.sae_pwe = 2;
98+
set_default(config, 'sae_pwe', 2);
10099
}
101100

102101
if (config.own_ip_addr)

0 commit comments

Comments
 (0)