Skip to content

Commit c3cf33f

Browse files
dastyhauke
authored andcommitted
ath79: fix build of big images for TP RE355v1, RE450v1 & v2
After merge of openwrt/openwrt#20709 I noticed, that https://mirror-03.infra.openwrt.org/snapshots/targets/ath79/tiny/ still does not contain the build for RE450. I analyzed the problem and noticed, that only builds which fits into original size can be build and if the image is larger, it fails with the following error: "WARNING: Image file .../openwrt/build_dir/ target-mips_24kc_musl/linux-ath79_tiny/tmp/ openwrt-ath79-tiny-tplink_re450-v1-squashfs-sysupgrade.bin is too big: > 7864320". This error is quite misleading as the image is smaller than 7864320. The reason for this error is that default tplink-safeloader has hardcoded factory partition structure and fails to generate any file. Rather then fixing tplink-safeloader I followed approach from commit ebd5e5f ("ramips: switched TP-Link RE305 v1 to new partition layout") and switched away from "tplink-safeloader sysupgrade". I did not include "IMAGES := sysupgrade.bin", because with tiny target it is still possible to locally build even factory image. Fixes commit e768731 ("ath79: switch TP-Link RE355 v1, RE450 v1 and RE450 v2 to mtd-concat"). Signed-off-by: Radek Dostál <[email protected]> Link: openwrt/openwrt#21158 Signed-off-by: Hauke Mehrtens <[email protected]> (cherry picked from commit bdbb4bd)
1 parent 623e329 commit c3cf33f

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

target/linux/ath79/image/tiny-tp-link.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ define Device/tplink_rex5x-v1
99
DEVICE_COMPAT_VERSION := 2.0
1010
DEVICE_COMPAT_MESSAGE := Partition layout has changed compared to older versions by utilizing unused flash. \
1111
Upgrade via sysupgrade mechanism (-F) will only work if flashed image still fits to the size of old partition (6016 KiB).
12+
IMAGE/sysupgrade.bin := append-kernel | append-rootfs | pad-rootfs | check-size | append-metadata
1213
endef
1314

1415
define Device/tplink_re355-v1
@@ -40,6 +41,7 @@ define Device/tplink_re450-v2
4041
DEVICE_COMPAT_VERSION := 2.0
4142
DEVICE_COMPAT_MESSAGE := Partition layout has changed compared to older versions by utilizing unused flash. \
4243
Upgrade via sysupgrade mechanism (-F) will only work if flashed image still fits to the size of old partition (6016 KiB).
44+
IMAGE/sysupgrade.bin := append-kernel | append-rootfs | pad-rootfs | check-size | append-metadata
4345
TPLINK_BOARD_ID := RE450-V2
4446
LOADER_TYPE := elf
4547
endef

0 commit comments

Comments
 (0)