Skip to content

Commit ce660d9

Browse files
Mikhail Zadorozhnyihauke
authored andcommitted
mvebu: gl-mv1000: fix sdhci1 controller
GL-MV1000 external SD controller was broken by a recent kernel update between OpenWRT releases 24.10.2 and 24.10.3 due to a mistake in Device Tree: "regulator-gpio" was defined without required "gpios" property. Since "no-1-8-v" property is also defined for this controller a switchable vqmmc-supply regulator performs no function - a fixed 3.3V IO voltage will always be used. This regulator definition was probably added by mistake from a Device Tree from another device. Remove incomplete vcc_sd_reg1 regulator definition to fix this issue. Issue discussion for reference: openwrt/openwrt#20309 Upstream commit: 6f2325b Signed-off-by: Mikhail Zadorozhnyi <zador.blood.stained+git@protonmail.com> Link: openwrt/openwrt#20378 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
1 parent 237b1c2 commit ce660d9

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

target/linux/mvebu/files-6.6/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,6 @@
2626
reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
2727
};
2828

29-
vcc_sd_reg1: regulator {
30-
compatible = "regulator-gpio";
31-
regulator-name = "vcc_sd1";
32-
regulator-min-microvolt = <1800000>;
33-
regulator-max-microvolt = <3300000>;
34-
regulator-boot-on;
35-
36-
gpios-states = <0>;
37-
states = <1800000 0x1
38-
3300000 0x0>;
39-
enable-active-high;
40-
};
41-
4229
keys {
4330
compatible = "gpio-keys";
4431

@@ -149,7 +136,6 @@
149136
cd-gpios = <&gpionb 17 GPIO_ACTIVE_LOW>;
150137
marvell,pad-type = "sd";
151138
no-1-8-v;
152-
vqmmc-supply = <&vcc_sd_reg1>;
153139
status = "okay";
154140
};
155141

0 commit comments

Comments
 (0)