Skip to content

Commit dcf11c8

Browse files
efahlhauke
authored andcommitted
mediatek: filogic: fix supported_devices list for gl-mt2500
The SUPPORTED_DEVICES sets for both Maxlinear (v1) and Airoha (v2) devices were identical, so sysupgrade was unable to detect when an incorrect image was being installed. This caused "soft bricking" of devices when a v1 image was installed on a v2 device, and vice versa. Fix this by making the supported_devices distinct for each device version, by renaming the devices with a version-specific name. This is reflected in the file name and the image metadata. Fixes: openwrt/openwrt#20566 Fixes: openwrt/asu#1525 Signed-off-by: Eric Fahlgren <[email protected]> Link: openwrt/openwrt#20632 Signed-off-by: Hauke Mehrtens <[email protected]> (cherry picked from commit b71f466)
1 parent b023a06 commit dcf11c8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

target/linux/mediatek/image/filogic.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,7 @@ define Device/glinet_gl-mt2500
980980
DEVICE_DTS_DIR := ../dts
981981
DEVICE_DTS_LOADADDR := 0x47000000
982982
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3
983-
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500-airoha
983+
SUPPORTED_DEVICES += glinet,mt2500-emmc
984984
IMAGES := sysupgrade.bin
985985
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
986986
endef
@@ -994,7 +994,7 @@ define Device/glinet_gl-mt2500-airoha
994994
DEVICE_DTS_DIR := ../dts
995995
DEVICE_DTS_LOADADDR := 0x47000000
996996
DEVICE_PACKAGES := -wpad-basic-mbedtls e2fsprogs f2fsck mkf2fs kmod-usb3 kmod-phy-airoha-en8811h airoha-en8811h-firmware
997-
SUPPORTED_DEVICES += glinet,mt2500-emmc glinet,gl-mt2500
997+
SUPPORTED_DEVICES += glinet,mt2500-emmc
998998
IMAGES := sysupgrade.bin
999999
IMAGE/sysupgrade.bin := sysupgrade-tar | append-gl-metadata
10001000
endef

0 commit comments

Comments
 (0)