Skip to content

Commit fcb07b0

Browse files
tofurkyrobimarko
authored andcommitted
build: propagate errors when generating apk indexes
The build would continue even if the some of the intermediate commands failed, as long as the last command in the final iteration of the loop was successful. Add 'set -e' to the subshell so that we immediately exit. Previously, only the exit status of the final make-index-json.py mattered. Fixes: openwrt/openwrt#21981 Signed-off-by: Matt Merhar <mattmerhar@protonmail.com> Link: openwrt/openwrt#21993 Signed-off-by: Robert Marko <robimarko@gmail.com>
1 parent dfd15dc commit fcb07b0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

package/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ $(curdir)/index: FORCE
129129
@echo Generating package index...
130130
ifneq ($(CONFIG_USE_APK),)
131131
@for d in $(PACKAGE_SUBDIRS); do \
132+
set -e; \
132133
mkdir -p $$d; \
133134
cd $$d || continue; \
134135
ls *.apk >/dev/null 2>&1 || continue; \

0 commit comments

Comments
 (0)