Merge pull request #2 from ledjon-behluli/fix-same-index-selection-potential

Fixes problem of potentially selecting same silo via the same index

Author: ledjon-behluli

Orleans.BalancedResourcePlacement/BalancedResourcePlacementDirector.cs

@@ -53,6 +53,8 @@ public Task<SiloAddress> OnAddActivation(PlacementStrategy strategy, PlacementTa
             int index = Random.Shared.Next(relevantSilos.Count);
             var pickedSilo = relevantSilos[index];
 
+            relevantSilos.RemoveAt(index);
+
             float score = CalculateScore(pickedSilo.Value);
             chooseFromSilos.Add(pickedSilo.Key, score);
         }

Orleans.BalancedResourcePlacement/WindowsEnvironmentStatistics.cs

@@ -5,7 +5,7 @@
 
 namespace Orleans.BalancedResourcePlacement;
 
-internal class WindowsEnvironmentStatistics : IHostEnvironmentStatistics, ILifecycleObserver, IDisposable
+internal sealed class WindowsEnvironmentStatistics : IHostEnvironmentStatistics, ILifecycleObserver, IDisposable
 {
     private readonly TimeSpan monitorPeriod;