refactor: address reviewer comments and reduce code duplication

- CI: split snitch-kernels and snitch-models into separate jobs (matching Siracusa pattern)
- Revert out-of-scope LoweringOptimizationPasses.py change
- Merge duplicate FloatDivTileConstraint/FloatMulTileConstraint into FloatScalarBOPTileConstraint
- Consolidate TileConstraint imports in Tiler.py
- Remove unused imports (NodeParser in Parsers.py, BasicConcatBindings in Platform.py)

Author: lee2716

.github/workflows/ci-platform-snitch.yml

@@ -35,4 +35,12 @@ jobs:
     with:
       runner: ${{ needs.select-env.outputs.runner }}
       docker-image: ${{ needs.select-env.outputs.image }}
-      pytest-marker: "(kernels or models)"
+      pytest-marker: kernels
+
+  snitch-models:
+    needs: select-env
+    uses: ./.github/workflows/_runner-snitch.yml
+    with:
+      runner: ${{ needs.select-env.outputs.runner }}
+      docker-image: ${{ needs.select-env.outputs.image }}
+      pytest-marker: models

Deeploy/CommonExtensions/OptimizationPasses/TopologyOptimizationPasses/LoweringOptimizationPasses.py

@@ -488,9 +488,7 @@ def _remove_global_output_reshape_fun(graph: gs.Graph, match: Match, name: str):
     node = next(iter((match.nodes_map.values())))
 
     isGlobalOutput = len(node.outputs[0].outputs) == 0
-    # Don't delete if the input is also a global input (i.e., single-node graph)
-    isGlobalInput = node.inputs[0] in graph.inputs
-    if isGlobalOutput and not isGlobalInput:
+    if isGlobalOutput:
         graph.deleteNode(node)
 
     return graph

Deeploy/Targets/Snitch/Parsers.py

@@ -7,7 +7,7 @@
 import numpy as np
 import onnx_graphsurgeon as gs
 
-from Deeploy.DeeployTypes import NetworkContext, NodeParser
+from Deeploy.DeeployTypes import NetworkContext
 from Deeploy.Targets.Generic.Parsers import AddParser, DivParser, GEMMParser, MulParser, RQGEMMParser, \
     iHardswishParser, iRMSNormParser
 

Deeploy/Targets/Snitch/Platform.py

@@ -9,8 +9,8 @@
 from Deeploy.AbstractDataTypes import Pointer, PointerClass, VoidType
 from Deeploy.DeeployTypes import ConstantBuffer, DeploymentEngine, DeploymentPlatform, NodeMapper, NodeTemplate, \
     StructBuffer, TopologyOptimizer, TransientBuffer, VariableBuffer
-from Deeploy.Targets.Generic.Bindings import BasicConcatBindings, BasicLayerNormBindings, BasicPad1DBindings, \
-    BasicPad2DBindings, BasicReshapeBindings, BasicRQIntegerDivBinding
+from Deeploy.Targets.Generic.Bindings import BasicLayerNormBindings, BasicPad1DBindings, BasicPad2DBindings, \
+    BasicReshapeBindings, BasicRQIntegerDivBinding
 from Deeploy.Targets.Generic.Layers import AddLayer, ConcatLayer, DivLayer, GatherLayer, GEMMLayer, HardSwishLayer, \
     LayerNormLayer, MatMulLayer, MulLayer, PadLayer, ReshapeLayer, RMSNormLayer, RQGEMMLayer, RQIntegerDivLayer, \
     SoftmaxLayer, TransposeLayer, iNoNormLayer

Deeploy/Targets/Snitch/TileConstraints/FloatMulTileConstraint.py

@@ -16,8 +16,13 @@
     VariableReplacementScheme
 
 
-class FloatDivTileConstraint(TileConstraint):
-    """Tile constraint for FP32 Div: supports scalar and element-wise cases."""
+class FloatScalarBOPTileConstraint(TileConstraint):
+    """Tile constraint for binary operators with scalar broadcasting support.
+
+    Extends BOPTileConstraint with scalar handling: when one input has size 1,
+    it is loaded in full (not tiled) while the other input and output are tiled together.
+    Used by FP32 Div and Mul operators.
+    """
 
     dataIn1Name = "A"
     dataIn2Name = "B"

…ileConstraints/FloatDivTileConstraint.py …straints/FloatScalarBOPTileConstraint.pyDeeploy/Targets/Snitch/TileConstraints/FloatDivTileConstraint.py renamed to Deeploy/Targets/Snitch/TileConstraints/FloatScalarBOPTileConstraint.py Deeploy/Targets/Snitch/TileConstraints/FloatDivTileConstraint.py renamed to Deeploy/Targets/Snitch/TileConstraints/FloatScalarBOPTileConstraint.py

@@ -3,7 +3,8 @@
 # SPDX-License-Identifier: Apache-2.0
 
 from . import *
-from .FloatDivTileConstraint import *
-from .FloatMulTileConstraint import *
+from .FloatScalarBOPTileConstraint import *
+from .GemmTileConstraint import *
 from .iNoNormTileConstraint import *
 from .iSoftmaxTileConstraint import *
+from .RqGemmTileConstraint import *

Deeploy/Targets/Snitch/TileConstraints/__init__.py

@@ -14,11 +14,8 @@
     SnitchGatherBindings, SnitchGemmBindings, SnitchHardSwishBindings, SnitchiNoNormBindings, SnitchiSoftmaxBindings, \
     SnitchMatMulBindings, SnitchMulBindings, SnitchReshapeBindings, SnitchRMSNormBindings, SnitchRQAddBindings, \
     SnitchRqGemmBindings, SnitchTransposeBindings
-from Deeploy.Targets.Snitch.TileConstraints import iNoNormTileConstraint, iSoftmaxTileConstraint
-from Deeploy.Targets.Snitch.TileConstraints.FloatDivTileConstraint import FloatDivTileConstraint
-from Deeploy.Targets.Snitch.TileConstraints.FloatMulTileConstraint import FloatMulTileConstraint
-from Deeploy.Targets.Snitch.TileConstraints.GemmTileConstraint import GemmTileConstraint
-from Deeploy.Targets.Snitch.TileConstraints.RqGemmTileConstraint import RqGemmTileConstraint
+from Deeploy.Targets.Snitch.TileConstraints import FloatScalarBOPTileConstraint, GemmTileConstraint, \
+    iNoNormTileConstraint, iSoftmaxTileConstraint, RqGemmTileConstraint
 from Deeploy.TilingExtension.TilerExtension import TilingReadyNodeBindings
 
 SnitchiSoftmaxTilingReadyBindings = TilingReadyNodeBindings(nodeBindings = SnitchiSoftmaxBindings,
@@ -42,10 +39,10 @@
                                                              tileConstraint = iHardswishTileConstraint())
 
 SnitchDivTilingReadyBindings = TilingReadyNodeBindings(nodeBindings = SnitchDivBindings,
-                                                       tileConstraint = FloatDivTileConstraint())
+                                                       tileConstraint = FloatScalarBOPTileConstraint())
 
 SnitchMulTilingReadyBindings = TilingReadyNodeBindings(nodeBindings = SnitchMulBindings,
-                                                       tileConstraint = FloatMulTileConstraint())
+                                                       tileConstraint = FloatScalarBOPTileConstraint())
 
 SnitchMatMulTilingReadyBindings = TilingReadyNodeBindings(nodeBindings = SnitchMatMulBindings,
                                                           tileConstraint = MatMulTileConstraint())