Skip to content

Conversation

@geeksbaek
Copy link
Collaborator

@geeksbaek geeksbaek commented Dec 31, 2025

Summary

  • Category.swift.specialItems 케이스를 추가하여 Tools 카테고리에서 특수 아이템(폭죽, 부채, 바람개비 등)을 분리할 수 있도록 함
  • 아이콘으로 icon-present 설정
  • 한국어(특수 아이템) / 영어(Special Items) Localizable.strings에 번역 추가

Test plan

  • 앱 빌드 확인
  • 카테고리 목록에서 특수 아이템이 도구 다음에 표시되는지 확인
  • 특수 아이템 카테고리 아이콘이 정상적으로 표시되는지 확인
  • 한국어/영어 로케일에서 카테고리 이름이 올바르게 표시되는지 확인

Closes #57

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • New Features
    • Added a new "Special Items" category to organize items and furniture in the app.
    • Category is localized and available in both English and Korean language versions.

✏️ Tip: You can customize this high-level summary in your review settings.

Tools 카테고리에서 폭죽, 부채, 바람개비 등 특수 아이템을 분리하기 위한
새로운 카테고리를 추가합니다.

- Category.swift에 .specialItems 케이스 추가
- 아이콘으로 icon-present 설정
- 한국어/영어 Localizable.strings에 번역 추가

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 31, 2025

Warning

Rate limit exceeded

@geeksbaek has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0caddc4 and 9b83868.

📒 Files selected for processing (1)
  • Animal-Crossing-Wiki/Projects/App/Sources/Models/Items/Category.swift
📝 Walkthrough

Walkthrough

This change introduces a new "Special Items" category to the Animal Crossing Wiki application, adding localization strings in English and Korean, and updating the Category enum model to support the new category with appropriate icon mappings and sort ordering.

Changes

Cohort / File(s) Summary
Localization Strings
Animal-Crossing-Wiki/Projects/App/Resources/en.lproj/Localizable.strings, Animal-Crossing-Wiki/Projects/App/Resources/ko.lproj/Localizable.strings
Added new localization entries for "Special Items" category in English ("Special Items") and Korean ("특수 아이템") within the category section.
Category Model
Animal-Crossing-Wiki/Projects/App/Sources/Models/Items/Category.swift
Added new enum case .specialItems with icon name "icon-present"; included in items() and furniture() static function arrays; updated sortOrder with .specialItems assigned order 6, causing reordering of downstream priorities (housewares 7, miscellaneous 8, ..., gyroids 30).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A new category hops into view,
Special Items bright and new,
Tools and trinkets sorted with care,
In English, Korean, everywhere—
The sorting order adjusted just right,
Our app now shines with categories bright! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The PR description covers the main implementation details and test plan, but does not follow the provided template structure with required sections like Issue URL, work type checkboxes, and merge checklist. Follow the repository template by adding Issue URL section, selecting the work type checkbox, and completing the merge checklist items.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main feature: adding a special items category. It's concise, specific, and directly reflects the primary code change in the PR.
Linked Issues check ✅ Passed The code changes successfully implement the requirement from issue #57: adding a specialItems category, configuring icons, and adding localizations for Korean and English.
Out of Scope Changes check ✅ Passed All code changes are directly related to issue #57 requirements: the new category case, icon configuration, localizations, and sort order updates are all necessary for the special items feature.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Category sortOrder 중복 및 == 연산자 버그 수정

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@leeari95
Copy link
Owner

leeari95 commented Jan 4, 2026

특수아이템 카테고리를 추가하는게 아니라 '도구' 카테고리에서 별도로 하위 카테고리로 분류할 수 있도록 구성해야함.

@leeari95 leeari95 closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[피드백] 도구, 폭죽, 부채 같은 아이템을 따로 분류하여 카테고리로 추가

3 participants