Skip to content

Commit 028f798

Browse files
committed
Tiling: fix edge case
1 parent c22b369 commit 028f798

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

ggml_extend.hpp

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,9 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
483483
int x,
484484
int y,
485485
int overlap_x,
486-
int overlap_y) {
486+
int overlap_y,
487+
int x_skip = 0,
488+
int y_skip = 0) {
487489
int64_t width = input->ne[0];
488490
int64_t height = input->ne[1];
489491
int64_t channels = input->ne[2];
@@ -492,16 +494,16 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
492494
int64_t img_height = output->ne[1];
493495

494496
GGML_ASSERT(input->type == GGML_TYPE_F32 && output->type == GGML_TYPE_F32);
495-
for (int iy = 0; iy < height; iy++) {
496-
for (int ix = 0; ix < width; ix++) {
497+
for (int iy = y_skip; iy < height; iy++) {
498+
for (int ix = x_skip; ix < width; ix++) {
497499
for (int k = 0; k < channels; k++) {
498500
float new_value = ggml_tensor_get_f32(input, ix, iy, k);
499501
if (overlap_x > 0 && overlap_y > 0) { // blend colors in overlapped area
500502
float old_value = ggml_tensor_get_f32(output, x + ix, y + iy, k);
501503

502-
const float x_f_0 = (overlap_x > 0 && x > 0) ? ix / float(overlap_x) : 1;
504+
const float x_f_0 = (overlap_x > 0 && x > 0) ? (ix - x_skip) / float(overlap_x) : 1;
503505
const float x_f_1 = (overlap_x > 0 && x < (img_width - width)) ? (width - ix) / float(overlap_x) : 1;
504-
const float y_f_0 = (overlap_y > 0 && y > 0) ? iy / float(overlap_y) : 1;
506+
const float y_f_0 = (overlap_y > 0 && y > 0) ? (iy - y_skip) / float(overlap_y) : 1;
505507
const float y_f_1 = (overlap_y > 0 && y < (img_height - height)) ? (height - iy) / float(overlap_y) : 1;
506508

507509
const float x_f = std::min(std::min(x_f_0, x_f_1), 1.f);
@@ -751,10 +753,10 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
751753
input_tile_size = tile_size * scale;
752754
output_tile_size = tile_size;
753755
}
754-
int num_tiles_x = (float)(input_width - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
756+
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
755757
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
756758

757-
int num_tiles_y = (float)(input_height - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
759+
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
758760
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
759761

760762
LOG_DEBUG("optimal overlap : %f, %f (targeting %f)", tile_overlap_factor_x, tile_overlap_factor_y, tile_overlap_factor);
@@ -794,22 +796,28 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
794796
bool last_y = false, last_x = false;
795797
float last_time = 0.0f;
796798
for (int y = 0; y < input_height && !last_y; y += non_tile_overlap_y) {
799+
int dy = 0;
797800
if (y + input_tile_size >= input_height) {
801+
int _y = y;
798802
y = input_height - input_tile_size;
803+
dy = _y - y;
799804
last_y = true;
800805
}
801806
for (int x = 0; x < input_width && !last_x; x += non_tile_overlap_x) {
807+
int dx = 0;
802808
if (x + input_tile_size >= input_width) {
809+
int _x = x;
803810
x = input_width - input_tile_size;
811+
dx = _x - x;
804812
last_x = true;
805813
}
806814
int64_t t1 = ggml_time_ms();
807815
ggml_split_tensor_2d(input, input_tile, x, y);
808816
on_processing(input_tile, output_tile, false);
809817
if (scaled_out) {
810-
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale);
818+
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale, dx * scale, dy * scale);
811819
} else {
812-
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale);
820+
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale, dx / scale, dy / scale);
813821
}
814822
int64_t t2 = ggml_time_ms();
815823
last_time = (t2 - t1) / 1000.0f;

0 commit comments

Comments
 (0)