Skip to content

Commit 0956861

Browse files
committed
Tiling: fix crash when less than 2 tiles per dim
1 parent b9fb001 commit 0956861

File tree

1 file changed

+21
-2
lines changed

1 file changed

+21
-2
lines changed

ggml_extend.hpp

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
376376
for (int ix = x_skip; ix < width; ix++) {
377377
for (int k = 0; k < channels; k++) {
378378
float new_value = ggml_tensor_get_f32(input, ix, iy, k);
379-
if (overlap_x > 0 && overlap_y > 0) { // blend colors in overlapped area
379+
if (overlap_x > 0 || overlap_y > 0) { // blend colors in overlapped area
380380
float old_value = ggml_tensor_get_f32(output, x + ix, y + iy, k);
381381

382382
const float x_f_0 = (overlap_x > 0 && x > 0) ? (ix - x_skip) / float(overlap_x) : 1;
@@ -510,12 +510,31 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
510510
input_tile_size = tile_size * scale;
511511
output_tile_size = tile_size;
512512
}
513-
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
513+
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1. - tile_overlap_factor));
514514
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
515+
if (num_tiles_x <= 1) {
516+
if (input_width == input_tile_size) {
517+
num_tiles_x = 1;
518+
tile_overlap_factor_x = 0;
519+
} else {
520+
num_tiles_x = 2;
521+
tile_overlap_factor_x = (2 * input_tile_size - input_width) / (float)input_tile_size;
522+
}
523+
}
515524

516525
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
517526
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
527+
if (num_tiles_y <= 1) {
528+
if (input_height == input_tile_size) {
529+
num_tiles_y = 1;
530+
tile_overlap_factor_y = 0;
531+
} else {
532+
num_tiles_y = 2;
533+
tile_overlap_factor_y = (2 * input_tile_size - input_height) / (float)input_tile_size;
534+
}
535+
}
518536

537+
LOG_DEBUG("num tiles : %d, %d ", num_tiles_x, num_tiles_y);
519538
LOG_DEBUG("optimal overlap : %f, %f (targeting %f)", tile_overlap_factor_x, tile_overlap_factor_y, tile_overlap_factor);
520539

521540
GGML_ASSERT(input_width % 2 == 0 && input_height % 2 == 0 && output_width % 2 == 0 && output_height % 2 == 0); // should be multiple of 2

0 commit comments

Comments
 (0)