Skip to content

Commit 69aad86

Browse files
committed
Revert "Use all of the clip" (it's breaking things)
This reverts commit de973c1.
1 parent 6ed5609 commit 69aad86

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

conditioner.hpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,9 @@ struct FluxCLIPEmbedder : public Conditioner {
10961096
size_t chunk_len_t5 = 256;
10971097
size_t chunk_count_t5 = t5_tokens.size() / chunk_len_t5;
10981098

1099-
size_t chunk_count = std::max(chunk_count_t5, chunk_count_l);
1099+
// TODO: I believe chunk_count_l is actually bigger than chunk_count_t5
1100+
// So this ignores some tokens for clip
1101+
size_t chunk_count = chunk_count_t5;
11001102

11011103
for (int chunk_idx = 0; chunk_idx < chunk_count; chunk_idx++) {
11021104
struct ggml_tensor* chunk_hidden_states_l = NULL; // [n_token, hidden_size_l]

0 commit comments

Comments
 (0)