Skip to content

Conversation

Seas0
Copy link
Contributor

@Seas0 Seas0 commented Aug 1, 2025

Just like in llama.cpp and whisper.cpp

@leejet leejet merged commit 6167e29 into leejet:master Aug 2, 2025
8 checks passed
@leejet
Copy link
Owner

leejet commented Aug 2, 2025

Thank you for your contribution.

@wbruna
Copy link
Contributor

wbruna commented Aug 2, 2025

Wouldn't this cause a sizeof (struct ggml_tensor) mismatch between the system ggml and sd.cpp, since sd.cpp overrides GGML_MAX_NAME default value?

@leejet @Green-Sky

@Green-Sky
Copy link
Contributor

Oh yea. We need static_assert(GGML_MAX_NAME >= 128) or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants