Remove hard-coded version, manage test version from Mill

Author: lefou

build.mill

@@ -235,6 +235,7 @@ object Deps {
     val errorProneCore = ivy"com.google.errorprone:error_prone_core:2.31.0"
     val freemarker = ivy"org.freemarker:freemarker:2.3.34"
     val jupiterInterface = ivy"com.github.sbt.junit:jupiter-interface:0.13.3"
+    val kotestJvm = ivy"io.kotest:kotest-framework-multiplatform-plugin-embeddable-compiler-jvm:5.9.1"
     val kotlinxHtmlJvm = ivy"org.jetbrains.kotlinx:kotlinx-html-jvm:0.11.0"
     val koverCli = ivy"org.jetbrains.kotlinx:kover-cli:$koverVersion"
     val koverJvmAgent = ivy"org.jetbrains.kotlinx:kover-jvm-agent:$koverVersion"
@@ -253,6 +254,7 @@ object Deps {
       errorProneCore,
       freemarker,
       jupiterInterface,
+      kotestJvm,
       kotlinxHtmlJvm,
       koverCli,
       koverJvmAgent,
@@ -574,7 +576,8 @@ trait MillBaseTestsModule extends TestModule {
       s"-DTEST_ZINC_VERSION=${Deps.zinc.version}",
       s"-DTEST_KOTLIN_VERSION=${Deps.kotlinCompiler.version}",
       s"-DTEST_SBT_VERSION=${Deps.sbt.version}",
-      s"-DTEST_PROGUARD_VERSION=${Deps.RuntimeDeps.proguard.version}"
+      s"-DTEST_PROGUARD_VERSION=${Deps.RuntimeDeps.proguard.version}",
+      s"-DTEST_KOTEST_VERSION=${Deps.RuntimeDeps.kotestJvm.version}"
     )
   }
 

kotlinlib/src/mill/kotlinlib/js/KotlinJsModule.scala

@@ -686,8 +686,11 @@ trait KotlinJsModule extends KotlinModule { outer =>
    */
   trait KotestTests extends KotlinJsTests {
 
-    // FIXME: get this version from Mill build info
-    def kotestVersion: T[String] = "5.9.1"
+    /**
+     * The version of Kotest to download from Maven.
+     * https://mvnrepository.com/artifact/io.kotest/kotest-framework-multiplatform-plugin-embeddable-compiler-jvm
+     */
+    def kotestVersion: T[String]
 
     override def kotlincPluginIvyDeps: T[Seq[Dep]] =
       super.kotlincPluginIvyDeps() ++ Seq(

kotlinlib/test/src/mill/kotlinlib/js/KotlinJsKotestModuleTests.scala

@@ -11,6 +11,7 @@ object KotlinJsKotestModuleTests extends TestSuite {
 
   private val testResourcePath = os.Path(sys.env("MILL_TEST_RESOURCE_DIR")) / "kotlin-js"
   private val testKotlinVersion = "1.9.25"
+  val testKotestVersion = sys.props.getOrElse("TEST_KOTEST_VERSION", ???)
 
   object module extends TestBaseModule {
 
@@ -24,6 +25,7 @@ object KotlinJsKotestModuleTests extends TestSuite {
       override def moduleDeps = Seq(module.bar)
 
       object test extends KotlinJsModule with KotestTests {
+        override def kotestVersion = Tast.Input(testKotestVersion)
         override def allSourceFiles = super.allSourceFiles()
           .filter(!_.path.toString().endsWith("HelloKotlinTestPackageTests.kt"))
       }