Fix clang and gcc build errors, upgrade gcc

Author: lefticus

.github/workflows/ci.yml

@@ -32,7 +32,7 @@ jobs:
           - ubuntu-22.04
         compiler:
           # you can specify the version after `-` like "llvm-16.0.0".
-          - gcc-13
+          - gcc-14
         generator:
           - "Ninja Multi-Config"
         build_type:
@@ -45,7 +45,7 @@ jobs:
         include:
           # Add appropriate variables for gcov version required. This will intentionally break
           # if you try to use a compiler that does not have gcov set
-          - compiler: gcc-13
+          - compiler: gcc-14
             gcov_executable: gcov
             enable_ipo: On
 

examples/speed_test.cpp

@@ -19,7 +19,7 @@ auto evaluate(std::string_view input)
 
 template<typename Result> Result evaluate_to(std::string_view input)
 {
-  return std::get<Result>(std::get<lefticus::cons_expr<>::Atom>(evaluate(input).value));
+  return std::get<Result>(std::get<cons_expr_type::Atom>(evaluate(input).value));
 }
 
 int main()

include/cons_expr/cons_expr.hpp

@@ -1539,7 +1539,7 @@ struct cons_expr
   [[nodiscard]] constexpr auto make_callable(SExpr callable) noexcept
     requires std::is_function_v<Signature>
   {
-    auto impl = [this, callable]<typename Ret, typename... Params>(Ret (*)(Params...)) {
+    auto impl = [callable]<typename Ret, typename... Params>(Ret (*)(Params...)) {
       return [callable](cons_expr &engine, Params... params) {
         std::array<SExpr, sizeof...(Params)> args{ SExpr{ Atom{ params } }... };
         if constexpr (std::is_same_v<void, Ret>) {

src/ccons_expr/main.cpp

@@ -50,9 +50,8 @@ int main([[maybe_unused]] int argc, [[maybe_unused]] const char *argv[])
     }
 
     globals.clear();
-    for (std::size_t index = 0; auto [key, value] : evaluator.global_scope[{ 0, evaluator.global_scope.size() }]) {
+    for (auto [key, value] : evaluator.global_scope[{ 0, evaluator.global_scope.size() }]) {
       globals.push_back(std::format("{}: '{}'", to_string(evaluator, false, key), to_string(evaluator, true, value)));
-      ++index;
     }
   };