TESTING: tools

Author: legendecas

.github/workflows/tools.yml

@@ -294,8 +294,8 @@ jobs:
           allow-prereleases: true
       - run: ${{ matrix.run }}
         if: github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id
-        env:
-          GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
+        # env:
+          # GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
       - name: Generate commit message if not set
         if: env.COMMIT_MSG == '' && (github.event_name == 'schedule' || inputs.id == 'all' || inputs.id == matrix.id)
         run: |
@@ -305,7 +305,7 @@ jobs:
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         with:
-          token: ${{ secrets.GH_USER_TOKEN }}
+          # token: ${{ secrets.GH_USER_TOKEN }}
           branch: actions/tools-update-${{ matrix.id }}  # Custom branch *just* for this Action.
           delete-branch: true
           commit-message: ${{ env.COMMIT_MSG }}

tools/dep_updaters/update-inspector-protocol.sh

@@ -1,10 +1,12 @@
 #!/bin/sh
-set -e
+set -ex
 # Shell script to update inspector_protocol in the source tree to the version same with V8's.
 
 BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd)
 DEPS_DIR="$BASE_DIR/deps"
 
+git status --porcelain
+
 # shellcheck disable=SC1091
 . "$BASE_DIR/tools/dep_updaters/utils.sh"
 

tools/inspector_protocol/roll.py

@@ -35,6 +35,7 @@ def RunCmd(cmd):
   (stdoutdata, stderrdata) = p.communicate()
   if p.returncode != 0:
     raise Exception('%s: exit status %d', str(cmd), p.returncode)
+  print(f"error: {stderrdata.decode('utf-8') if stderrdata else 'None'}")
   return stdoutdata.decode('utf-8')
 
 
@@ -43,7 +44,11 @@ def CheckRepoIsClean(path):
   # If path isn't a git repo, this will throw and exception.
   # And if it is a git repo and 'git status' has anything interesting to say,
   # then it's not clean (uncommitted files etc.)
-  if len(RunCmd(['git', 'status', '--porcelain'])) != 0:
+  res = RunCmd(['git', 'status', '--porcelain'])
+  print(f"result type: {type(res)}, len: {len(res)}")
+  print(f"result: {res}")
+  if len(res) != 0:
+    sys.stdout.flush()
     raise Exception('%s is not a clean git repo (run git status)' % path)
 
 
@@ -125,10 +130,6 @@ def main(argv):
   CheckRepoIsClean(upstream)
   CheckRepoIsClean(downstream)
   CheckRepoIsInspectorProtocolCheckout(upstream)
-  # Check that the destination Git repo isn't at the main branch - it's
-  # generally a bad idea to check into the main branch, so we catch this
-  # common pilot error here early.
-  CheckRepoIsNotAtMainBranch(downstream)
 
   # Read V8's inspector_protocol revision
   v8_ip_revision = ReadV8IPRevision(downstream)