Skip to content

Commit 6ed55c7

Browse files
committed
Merge remote-tracking branch 'origin/fix/1470_no_file_found_error' into dev
2 parents d76cded + 49221d5 commit 6ed55c7

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

backend/src/services/file.service.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,9 @@ export class FileService implements OnModuleInit {
167167
.take(take)
168168
.skip(skip)
169169
.getManyAndCount();
170+
if (files.length === 0) {
171+
throw new Error('No files found.');
172+
}
170173

171174
return {
172175
data: files.map((element) => fileEntityToDto(element)),

cli/kleinkram/core.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from typing import Sequence
2323
from uuid import UUID
2424

25+
import httpx
2526
from rich.console import Console
2627
from tqdm import tqdm
2728

@@ -33,6 +34,7 @@
3334
from kleinkram.api.query import MissionQuery
3435
from kleinkram.api.query import ProjectQuery
3536
from kleinkram.api.query import check_mission_query_is_creatable
37+
from kleinkram.errors import InvalidFileQuery
3638
from kleinkram.errors import MissionNotFound
3739
from kleinkram.models import FileState
3840
from kleinkram.models import FileVerificationStatus
@@ -67,7 +69,12 @@ def download(
6769
raise ValueError(f"Destination {base_dir.absolute()} is not a directory")
6870

6971
# retrive files and get the destination paths
70-
files = list(kleinkram.api.routes.get_files(client, file_query=query))
72+
try:
73+
files = list(kleinkram.api.routes.get_files(client, file_query=query))
74+
except httpx.HTTPStatusError:
75+
raise InvalidFileQuery(
76+
f"Files not found. Maybe you forgot to specify mission or project flags: {query}"
77+
)
7178
paths = file_paths_from_files(files, dest=base_dir, allow_nested=nested)
7279

7380
if verbose:

0 commit comments

Comments
 (0)