Skip to content

Commit 203b612

Browse files
authored
Update Package Reader to Accept Range Versions in Dependencies (MetaMask#106)
1 parent c41cc8b commit 203b612

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/package-manifest.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ describe('package-manifest', () => {
6464
private: true,
6565
dependencies: {
6666
a: '1.0.0',
67+
b: '^2.0.0',
68+
c: '~4.3.0',
6769
},
6870
};
6971
const validated = {
@@ -73,6 +75,8 @@ describe('package-manifest', () => {
7375
private: true,
7476
dependencies: {
7577
a: '1.0.0',
78+
b: '^2.0.0',
79+
c: '~4.3.0',
7680
},
7781
peerDependencies: {},
7882
};
@@ -94,6 +98,8 @@ describe('package-manifest', () => {
9498
private: true,
9599
peerDependencies: {
96100
a: '1.0.0',
101+
b: '^2.0.0',
102+
c: '~4.3.0',
97103
},
98104
};
99105
const validated = {
@@ -104,6 +110,8 @@ describe('package-manifest', () => {
104110
dependencies: {},
105111
peerDependencies: {
106112
a: '1.0.0',
113+
b: '^2.0.0',
114+
c: '~4.3.0',
107115
},
108116
};
109117
await fs.promises.writeFile(manifestPath, JSON.stringify(unvalidated));

src/package-manifest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
import { isPlainObject } from '@metamask/utils';
77
import { readJsonObjectFile } from './fs';
88
import { isTruthyString } from './misc-utils';
9-
import { isValidSemver, SemVer } from './semver';
9+
import { semver, SemVer } from './semver';
1010

1111
export { PackageManifestFieldNames, PackageManifestDependenciesFieldNames };
1212

@@ -139,7 +139,7 @@ export function readPackageManifestNameField(
139139
function isValidPackageManifestVersionField(
140140
version: unknown,
141141
): version is string {
142-
return isTruthyString(version) && isValidSemver(version);
142+
return isTruthyString(version) && semver.validRange(version) !== null;
143143
}
144144

145145
/**

0 commit comments

Comments
 (0)