Skip to content

Commit 6714f0c

Browse files
leigaoltsmithszyueny2020Will-ShaoHuaatonaamz
authored
merge (#28)
* chore: merge release candidate version rc-20250815 (aws#7916) ## Problem This merges the released changes for rc-20250815 into main. MCM-132479224 ## Solution --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Lei Gao <[email protected]> Co-authored-by: Na Yue <[email protected]> Co-authored-by: Will Lo <[email protected]> Co-authored-by: Aidan Ton <[email protected]> Co-authored-by: atontb <[email protected]> * fix(sagemaker): Reduce number of reconnect retries (aws#7827) ## Problem When a connection to a remote space is severed, the extension will attempt to reconnect up to 60 times. Each reconnect attempt opens the Space Details page in a new browser tab. Opening up to 60 new tabs is a poor user experience. ## Solution We change the maximum number of retries to 8. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Newton Der <[email protected]> * fix(amazonq): do not auto trigger if the ongoing typeahead does not match (aws#7924) ## Problem Bug: When inline suggestion is active but user types a character that does not match the typeahead, this typing event triggered a inline completion API call that eventually did not manage to display suggestion on screen, which eventually reported as rejected completions. ## Solution Previously, before Flare migration, we had this design: https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/amazonq/src/app/inline/activation.ts#L108 Auto trigger will be disabled if at that moment the suggestion is visible. Under the previous design, the first character that does not match the typeahead will not make a new auto trigger, it simply rejects the current inline completion. This PR is to bring back the old design. It is not customer facing, hence no change log. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: tsmithsz <[email protected]> Co-authored-by: Na Yue <[email protected]> Co-authored-by: Will Lo <[email protected]> Co-authored-by: Aidan Ton <[email protected]> Co-authored-by: atontb <[email protected]> Co-authored-by: Newton Der <[email protected]> Co-authored-by: Newton Der <[email protected]>
1 parent f1aecae commit 6714f0c

File tree

7 files changed

+17
-5
lines changed

7 files changed

+17
-5
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/amazonq/.changes/1.90.0.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"date": "2025-08-15",
3+
"version": "1.90.0",
4+
"entries": []
5+
}

packages/amazonq/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.90.0 2025-08-15
2+
3+
- Miscellaneous non-user-facing changes
4+
15
## 1.89.0 2025-08-13
26

37
- Miscellaneous non-user-facing changes

packages/amazonq/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "amazon-q-vscode",
33
"displayName": "Amazon Q",
44
"description": "The most capable generative AI–powered assistant for software development.",
5-
"version": "1.90.0-SNAPSHOT",
5+
"version": "1.91.0-SNAPSHOT",
66
"extensionKind": [
77
"workspace"
88
],

packages/amazonq/src/app/inline/completion.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,9 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
391391
}
392392
this.languageClient.sendNotification(this.logSessionResultMessageName, params)
393393
this.sessionManager.clear()
394+
// Do not make auto trigger if user rejects a suggestion
395+
// by typing characters that does not match
396+
return []
394397
}
395398

396399
// tell the tutorial that completions has been triggered

packages/core/resources/sagemaker_connect

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ _get_ssm_session_info_async() {
4646
# Generate unique temporary file name to avoid conflicts
4747
local temp_file="/tmp/ssm_session_response_$$_$(date +%s%N).json"
4848

49-
local max_retries=60
49+
local max_retries=8
5050
local retry_interval=5
5151
local attempt=1
5252

packages/core/resources/sagemaker_connect.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function Get-SSMSessionInfoAsync {
5454
$url = "http://localhost:$LocalEndpointPort/get_session_async?connection_identifier=$AwsResourceArn&credentials_type=$CredentialsType&request_id=$requestId"
5555
Write-Host "Calling Get-SSMSessionInfoAsync with URL: $url"
5656

57-
$maxRetries = 60
57+
$maxRetries = 8
5858
$retryInterval = 5
5959

6060
for ($attempt = 1; $attempt -le $maxRetries; $attempt++) {

0 commit comments

Comments
 (0)