Skip to content

Commit cb83a7e

Browse files
makingleijendary
authored andcommitted
Fix flaky tests in PostgresMlEmbeddingModelIT
Signed-off-by: leijendary <[email protected]>
1 parent 90d3823 commit cb83a7e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

models/spring-ai-postgresml/src/main/java/org/springframework/ai/postgresml/PostgresMlEmbeddingModel.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ public float[] embed(String text) {
135135
return this.jdbcTemplate.queryForObject(
136136
"SELECT pgml.embed(?, ?, ?::JSONB)" + this.defaultOptions.getVectorType().cast + " AS embedding",
137137
this.defaultOptions.getVectorType().rowMapper, this.defaultOptions.getTransformer(), text,
138-
this.defaultOptions.getKwargs());
138+
ModelOptionsUtils.toJsonString(this.defaultOptions.getKwargs()));
139139
}
140140

141141
@Override
@@ -203,7 +203,6 @@ PostgresMlEmbeddingOptions mergeOptions(EmbeddingOptions requestOptions) {
203203
@Override
204204
public void afterPropertiesSet() {
205205
this.jdbcTemplate.execute("CREATE EXTENSION IF NOT EXISTS pgml");
206-
this.jdbcTemplate.execute("CREATE EXTENSION IF NOT EXISTS hstore");
207206
if (StringUtils.hasText(this.defaultOptions.getVectorType().extensionName)) {
208207
this.jdbcTemplate
209208
.execute("CREATE EXTENSION IF NOT EXISTS " + this.defaultOptions.getVectorType().extensionName);

models/spring-ai-postgresml/src/test/java/org/springframework/ai/postgresml/PostgresMlEmbeddingModelIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
@JdbcTest(properties = "logging.level.sql=TRACE")
5656
@AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.NONE)
5757
@Testcontainers
58-
@Disabled("Disabled from automatic execution, as it requires an excessive amount of memory (over 9GB)!")
58+
@Disabled("Disabled from automatic execution, as it pulls a very large image file (over 9GB)!")
5959
class PostgresMlEmbeddingModelIT {
6060

6161
@Container

0 commit comments

Comments
 (0)