omit <dimension> in native writer

Author: lekoala

docs/bench-read.md

@@ -1,17 +1,18 @@
-Results for csv
-
-```
-LeKoala\SpreadCompat\Csv\Native : 0.0161
-LeKoala\SpreadCompat\Csv\League : 0.1049
-LeKoala\SpreadCompat\Csv\OpenSpout : 0.3663
-LeKoala\SpreadCompat\Csv\PhpSpreadsheet : 6.2865
-```
-
-Results for xlsx
-
-```
-LeKoala\SpreadCompat\Xlsx\Native : 0.2062
-LeKoala\SpreadCompat\Xlsx\Simple : 0.3008
-LeKoala\SpreadCompat\Xlsx\OpenSpout : 3.5006
-LeKoala\SpreadCompat\Xlsx\PhpSpreadsheet : 8.6585
-```
+Results for csv
+
+```
+LeKoala\SpreadCompat\Csv\Native : 0.0051
+LeKoala\SpreadCompat\Csv\League : 0.0093
+LeKoala\SpreadCompat\Csv\OpenSpout : 0.0236
+LeKoala\SpreadCompat\Csv\PhpSpreadsheet : 0.3935
+```
+
+Results for xlsx
+
+```
+LeKoala\SpreadCompat\Xlsx\Native : 0.0699
+LeKoala\SpreadCompat\Xlsx\Simple : 0.0896
+LeKoala\SpreadCompat\Xlsx\OpenSpout : 0.2172
+LeKoala\SpreadCompat\Xlsx\PhpSpreadsheet : 0.4913
+```
+

docs/bench-write.md

@@ -1,17 +1,14 @@
-Results for csv
-
-```
-LeKoala\SpreadCompat\Csv\Native : 0.0087
-LeKoala\SpreadCompat\Csv\League : 0.0275
-LeKoala\SpreadCompat\Csv\OpenSpout : 0.1561
-LeKoala\SpreadCompat\Csv\PhpSpreadsheet : 3.1852
-```
-
-Results for xlsx
-
-```
-LeKoala\SpreadCompat\Xlsx\Native : 0.194
-LeKoala\SpreadCompat\Xlsx\OpenSpout : 0.9734
-LeKoala\SpreadCompat\Xlsx\Simple : 1.63
-LeKoala\SpreadCompat\Xlsx\PhpSpreadsheet : 6.0976
-```
+Results for csv
+
+LeKoala\SpreadCompat\Csv\Native : 0.0052
+LeKoala\SpreadCompat\Csv\League : 0.0072
+LeKoala\SpreadCompat\Csv\OpenSpout : 0.0188
+LeKoala\SpreadCompat\Csv\PhpSpreadsheet : 0.1976
+
+Results for xlsx
+
+LeKoala\SpreadCompat\Xlsx\Simple : 0.0355
+LeKoala\SpreadCompat\Xlsx\Native : 0.0494
+LeKoala\SpreadCompat\Xlsx\OpenSpout : 0.1305
+LeKoala\SpreadCompat\Xlsx\PhpSpreadsheet : 0.301
+

src/Xlsx/Native.php

@@ -476,16 +476,16 @@ protected function genWorksheet(iterable $data, bool $memory = true)
         $r = 0;
 
         // Since we don't know in advance, let's have the max
-        $MAX_ROW = 1048576;
-        $MAX_COL = 16384;
-
-        $maxCell = SpreadCompat::excelCell($MAX_ROW, $MAX_COL);
+        // $MAX_ROW = 1048576;
+        // $MAX_COL = 16384;
+        // $maxCell = SpreadCompat::excelCell($MAX_ROW, $MAX_COL);
+        // This would help to create <dimension ref="A1:XFE1048577"/> but it can be seen as broken
+        // This is why we simply omit the <dimension> tag
 
         $header = <<<XML
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main"
     xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships">
-    <dimension ref="A1:{$maxCell}"/>
     <cols>
         <col collapsed="false" hidden="false" max="1024" min="1" style="0" customWidth="false" width="11.5"/>
     </cols>