Skip to content

Methods prefixed with _set should not return values #107

@grovduck

Description

@grovduck

In a comment on #99, @aazuspan noted that there are a few methods in TreeNodeTransformer that begin with _set which currently return values. The other _set_* methods across sknnr (e.g. _set_dataframe_index_in and _set_fitted_transformer) modify the estimator attributes rather than returning, which is the preferred course.

We want the same behavior for these three methods in TreeNodeTransformer:

Rather than bury that fix within #99, it makes more sense to handle the change outside of that PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions