Add debug builds (and more output), fix port not being cleared before first getting settings (TeamOpenFIRE#85)

* Export debug builds in actions, print received input from board during sync

* Append build type to artifact, oops

* Because Wendies is cranky about RelWithDebugInfo

* Potential fixes for RaspPi?

Author: SeongGino

.github/workflows/cmake-multi-platform.yml

@@ -15,7 +15,7 @@ jobs:
       matrix:
         os: [ubuntu-22.04, ubuntu-22.04-arm, windows-2019]
         qt_version: [5.15.2, 6.7.3, 6.8.3]
-        build_type: [Release]
+        build_type: [Debug, Release]
         include:
           - os: windows-2019
             c_compiler: cl
@@ -137,7 +137,7 @@ jobs:
       uses: actions/upload-artifact@v4
       with:
         # Artifact name
-        name: OpenFIREapp-${{ matrix.pretty }}-Qt${{ matrix.qt_version }} # optional, default is artifact
+        name: OpenFIREapp-${{ matrix.pretty }}-Qt${{ matrix.qt_version }}-${{ matrix.build_type }} # optional, default is artifact
         # A file, directory or wildcard pattern that describes what to upload
         path: ${{ matrix.file }}
 

src/appserial.cpp

@@ -85,6 +85,9 @@ bool AppSerial::GetSettings(const QString &portName)
             port.clear();
 
             if(char buf[] = {(char)OF_Const::sDock1, (char)OF_Const::sDock2}; OneShotSend(buf, 2, true)) {
+                #ifdef OFAPP_DEBUG
+                qDebug() << port.peek(port.bytesAvailable());
+                #endif
                 QList<QByteArray> buffer = port.readLine().split((char)OF_Const::serialTerminator);
 
                 if(buffer.size() >= 3) {
@@ -113,6 +116,8 @@ bool AppSerial::GetSettings(const QString &portName)
                                   "Otherwise, the camera wires must be resoldered to resolve this error.</p>",
                                   QMessageBox::Warning);
 
+                    port.clear();
+
                     ////* toggles *////
                     if(OneShotSend((char)OF_Const::sGetToggles, true)) {
                         memset(App_Common::boolSettings, false, sizeof(App_Common::boolSettings));
@@ -280,15 +285,20 @@ bool AppSerial::BatchStoreSettings(void *dataPtr, const std::unordered_map<std::
                 }
             // String not detected, skip over
             } else {
-                printf("No data found for %s\n", buf.constData());
+                qDebug() << "No data found for" << buf;
                 // skip the profile num byte if reading profile type data
                 if(&dataMap == &App_Common::OFPresets.profSettingTypes_Strings) {
-                    if(!port.bytesAvailable()) if(!port.waitForReadyRead(500)) return false;
+                    if(!port.bytesAvailable()) port.waitForReadyRead(500);
                     buf += port.read(1);
                 }
-                if(port.bytesAvailable() < sizeRead) if(!port.waitForReadyRead(500)) return false;
+                if(port.bytesAvailable() < sizeRead) port.waitForReadyRead(500);
                 buf += port.read(sizeRead);
             }
+
+            #ifdef OFAPP_DEBUG
+            qDebug() << buf;
+            #endif
+
             // Report back received buffer to board for verification
             // (board will re-send output if buffers aren't matching)
             OneShotSend(buf.constData(), buf.length());