Skip to content

Commit fac923e

Browse files
author
Slobodan Josic
committed
Disable GGML_HIP_ROCWMMA_FATTN due to negative effect on PP numbers for bigger context sizes
1 parent f3e4e0c commit fac923e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/build-llamacpp-rocm.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ jobs:
312312
-DGGML_HIP=ON ^
313313
-DGGML_OPENMP=OFF ^
314314
-DGGML_CUDA_FORCE_CUBLAS=OFF ^
315-
-DGGML_HIP_ROCWMMA_FATTN=ON ^
315+
-DGGML_HIP_ROCWMMA_FATTN=OFF ^
316316
-DLLAMA_CURL=OFF ^
317317
-DGGML_NATIVE=OFF ^
318318
-DGGML_STATIC=OFF ^
@@ -720,7 +720,7 @@ jobs:
720720
-DGGML_HIP=ON \
721721
-DGGML_OPENMP=OFF \
722722
-DGGML_CUDA_FORCE_CUBLAS=OFF \
723-
-DGGML_HIP_ROCWMMA_FATTN=ON \
723+
-DGGML_HIP_ROCWMMA_FATTN=OFF \
724724
-DLLAMA_CURL=OFF \
725725
-DGGML_NATIVE=OFF \
726726
-DGGML_STATIC=OFF \

docs/manual_instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ set HIP_PLATFORM=amd
5050
cd "C:\<YOUR_LLAMACPP_PATH>\llama.cpp"
5151
mkdir build
5252
cd build
53-
cmake .. -G Ninja -DCMAKE_C_COMPILER="C:\opt\rocm\lib\llvm\bin\clang.exe" -DCMAKE_CXX_COMPILER="C:\opt\rocm\lib\llvm\bin\clang++.exe" -DCMAKE_CXX_FLAGS="-IC:\opt\rocm\include" -DCMAKE_CROSSCOMPILING=ON -DCMAKE_BUILD_TYPE=Release -DGPU_TARGETS="gfx1151" -DBUILD_SHARED_LIBS=ON -DLLAMA_BUILD_TESTS=OFF -DGGML_HIP=ON -DGGML_OPENMP=OFF -DGGML_CUDA_FORCE_CUBLAS=OFF -DGGML_HIP_ROCWMMA_FATTN=ON -DLLAMA_CURL=OFF -DGGML_NATIVE=OFF -DGGML_STATIC=OFF -DCMAKE_SYSTEM_NAME=Windows
53+
cmake .. -G Ninja -DCMAKE_C_COMPILER="C:\opt\rocm\lib\llvm\bin\clang.exe" -DCMAKE_CXX_COMPILER="C:\opt\rocm\lib\llvm\bin\clang++.exe" -DCMAKE_CXX_FLAGS="-IC:\opt\rocm\include" -DCMAKE_CROSSCOMPILING=ON -DCMAKE_BUILD_TYPE=Release -DGPU_TARGETS="gfx1151" -DBUILD_SHARED_LIBS=ON -DLLAMA_BUILD_TESTS=OFF -DGGML_HIP=ON -DGGML_OPENMP=OFF -DGGML_CUDA_FORCE_CUBLAS=OFF -DGGML_HIP_ROCWMMA_FATTN=OFF -DLLAMA_CURL=OFF -DGGML_NATIVE=OFF -DGGML_STATIC=OFF -DCMAKE_SYSTEM_NAME=Windows
5454
cmake --build . -j 24 2>&1 | findstr /i "error"
5555
```
5656

@@ -133,7 +133,7 @@ cmake .. -G Ninja \
133133
-DGGML_HIP=ON \
134134
-DGGML_OPENMP=OFF \
135135
-DGGML_CUDA_FORCE_CUBLAS=OFF \
136-
-DGGML_HIP_ROCWMMA_FATTN=ON \
136+
-DGGML_HIP_ROCWMMA_FATTN=OFF \
137137
-DLLAMA_CURL=OFF \
138138
-DGGML_NATIVE=OFF \
139139
-DGGML_STATIC=OFF \

0 commit comments

Comments
 (0)