Fix some rubocop offenses

Author: lemontree55

.rubocop.yml

@@ -1,7 +1,7 @@
-require:
+plugins:
   - rubocop-performance
 AllCops:
-  TargetRubyVersion: '3.0'
+  TargetRubyVersion: "3.0"
   NewCops: enable
   Exclude:
     - .git/**/*
@@ -20,11 +20,11 @@ Lint/EmptyWhen:
 Lint/Void:
   Enabled: false
 Metrics/AbcSize:
-    Max: 20
+  Max: 20
 Metrics/ClassLength:
-    Max: 200
+  Max: 200
 Metrics/MethodLength:
-    Max: 20
+  Max: 20
 Metrics/ParameterLists:
   MaxOptionalParameters: 4
 Style/AccessModifierDeclarations:
@@ -46,7 +46,7 @@ Style/PerlBackrefs:
   Enabled: false
 Style/RaiseArgs:
   EnforcedStyle: exploded
-  AllowedCompactTypes: ['ConstraintError', 'ChoiceError']
+  AllowedCompactTypes: ["ConstraintError", "ChoiceError"]
 Style/RedundantSelf:
   Enabled: false
 Style/StructInheritance:

lib/rasn1.rb

@@ -26,7 +26,7 @@ module RASN1
   # @param [String] der binary string to parse
   # @param [Boolean] ber if +true+, decode a BER string, else a DER one
   # @return [Types::Base]
-  def self.parse(der, ber: false) # rubocop:disable Metrics:AbcSize
+  def self.parse(der, ber: false) # rubocop:disable Metrics/AbcSize
     type = Types.id2type(der)
     type.parse!(der, ber: ber)
 

lib/rasn1/types/base.rb

@@ -359,7 +359,7 @@ def trace_data(data=nil)
             lines << str
           end
           str[compute_trace_index(byte_count, 3), 2] = '%02x' % byte
-          str[compute_trace_index(byte_count, 1, 49)] = byte >= 32 && byte <= 126 ? byte.chr : '.'
+          str[compute_trace_index(byte_count, 1, 49)] = byte.between?(32, 126) ? byte.chr : '.'
           byte_count += 1
         end
         lines.map(&:rstrip).join << "\n"
@@ -546,7 +546,11 @@ def encode_size(size)
         end
       end
 
-      def check_id(der)
+      # Check ID from +der+ is the one expected
+      # @return [Boolean] +true+ is ID is expected, +false+ if it is not but +self+ is {#optional?}
+      #   or has a {#default} value.
+      # @raise [ASN1Error] ID was not expected, is not optional and has no default value
+      def check_id(der) # rubocop:disable Naming/PredicateMethod
         expected_id = encode_identifier_octets
         real_id = der[0, expected_id.size]
         return true if real_id == expected_id

lib/rasn1/types/boolean.rb

@@ -14,7 +14,7 @@ class Boolean < Primitive
       DER_FALSE = 0
 
       # @return [false]
-      def void_value
+      def void_value # rubocop:disable Naming/PredicateMethod
         false
       end
 

lib/rasn1/types/visible_string.rb

@@ -4,7 +4,7 @@ module RASN1
   module Types
     # Create VisibleString as a Constrained subclass of IA5String
     Types.define_type(:VisibleString, from: IA5String) do |value|
-      value.nil? || value.chars.all? { |c| c.ord >= 32 && c.ord <= 126 }
+      value.nil? || value.chars.all? { |c| c.ord.between?(32, 126) }
     end
 
     # ASN.1 Visible String