Skip to content

Commit 204cef6

Browse files
committed
chore: resolve dcm findings in cache and git workflows
1 parent 6c2194d commit 204cef6

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

lib/src/services/flutter_service.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ class FlutterService extends ContextualService {
145145
if (useArchive) {
146146
final archiveService = get<ArchiveService>();
147147
await archiveService.install(version, versionDir);
148+
148149
return;
149150
}
150151

lib/src/services/git_service.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,15 @@ class GitService extends ContextualService {
112112
try {
113113
logger.debug('Updating local mirror...');
114114
final processService = get<ProcessService>();
115-
Future<ProcessResult> runInCache(List<String> args) {
115+
Future<ProcessResult> runInCache(List<String> args) async {
116116
if (isBareRepo) {
117-
return processService.run(
117+
return await processService.run(
118118
'git',
119119
args: ['--git-dir', gitCacheDir.path, ...args],
120120
);
121121
}
122122

123-
return processService.run(
123+
return await processService.run(
124124
'git',
125125
args: ['-C', gitCacheDir.path, ...args],
126126
);
@@ -159,6 +159,7 @@ class GitService extends ContextualService {
159159
gitCacheDir.deleteSync(recursive: true);
160160
}
161161
await _createLocalMirror();
162+
162163
return;
163164
}
164165
}

lib/src/workflows/ensure_cache.workflow.dart

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,9 @@ class EnsureCacheWorkflow extends Workflow {
206206
try {
207207
await gitService.updateLocalMirror();
208208
} on Exception catch (e) {
209-
logger.warn('Failed to setup local cache ($e). Falling back to git clone.');
209+
logger.warn(
210+
'Failed to setup local cache ($e). Falling back to git clone.',
211+
);
210212
// Do not rethrow, allow to fallback to clone
211213
}
212214
}
@@ -215,10 +217,7 @@ class EnsureCacheWorkflow extends Workflow {
215217
'Installing Flutter SDK: ${cyan.wrap(version.printFriendlyName)}',
216218
);
217219
try {
218-
await flutterService.install(
219-
version,
220-
useArchive: useArchive,
221-
);
220+
await flutterService.install(version, useArchive: useArchive);
222221

223222
progress.complete(
224223
'Flutter SDK: ${cyan.wrap(version.printFriendlyName)} installed!',

0 commit comments

Comments
 (0)