fix: improve install script behavior in CI environments (#1012)

* fix: improve install script behavior in CI environments

- Skip legacy v1/v2 migration in CI environments where it's not applicable
- Use non-interactive sudo (-n) to prevent hanging on password prompts
- Fix symlink removal detection to check both file existence and symlink status
- Exit with error code when binary fails to execute in CI (fail loudly)
- Test migration path by unsetting CI environment variables in test workflow

* fix: remove is_ci guard from migrate_from_v1 to fix CI test

The is_ci early return in migrate_from_v1 skipped migration entirely
in CI, causing the v1-to-v2 migration test to fail. The env overrides
(CI="", GITHUB_ACTIONS="") did not effectively disable CI detection.

Migration is safe to run in CI: sudo -n prevents hangs, error
suppression handles permission issues, and real CI has no legacy
installs to clean up. Remove the guard and the now-unnecessary
workflow env overrides.

Author: leoafarias

docs/public/install.sh

@@ -202,7 +202,7 @@ migrate_from_v1() {
     else
       # Try with sudo if available
       if command -v sudo >/dev/null 2>&1; then
-        sudo rm -f "$OLD_SYSTEM_PATH" 2>/dev/null || true
+        sudo -n rm -f "$OLD_SYSTEM_PATH" 2>/dev/null || true
         if [ ! -e "$OLD_SYSTEM_PATH" ] && [ ! -L "$OLD_SYSTEM_PATH" ]; then
           echo "✓ Removed old system symlink (required sudo)" >&2
           migrated=1
@@ -282,16 +282,16 @@ do_uninstall() {
     fi
   fi
 
-  # 3. Remove old system symlink (from v1/v2)
-  if [ -L "$OLD_SYSTEM_PATH" ]; then
+  # 3. Remove old system symlink (from v1/v2) — skip in CI (no legacy installs)
+  if ! is_ci && [ -L "$OLD_SYSTEM_PATH" ]; then
     rm -f "$OLD_SYSTEM_PATH" 2>/dev/null || true
-    if [ ! -e "$OLD_SYSTEM_PATH" ]; then
+    if [ ! -e "$OLD_SYSTEM_PATH" ] && [ ! -L "$OLD_SYSTEM_PATH" ]; then
       echo "✓ Removed old system symlink: $OLD_SYSTEM_PATH" >&2
       removed_any=1
     else
       if command -v sudo >/dev/null 2>&1; then
-        sudo rm -f "$OLD_SYSTEM_PATH" 2>/dev/null || true
-        if [ ! -e "$OLD_SYSTEM_PATH" ]; then
+        sudo -n rm -f "$OLD_SYSTEM_PATH" 2>/dev/null || true
+        if [ ! -e "$OLD_SYSTEM_PATH" ] && [ ! -L "$OLD_SYSTEM_PATH" ]; then
           echo "✓ Removed old system symlink: $OLD_SYSTEM_PATH" >&2
           removed_any=1
         else
@@ -301,7 +301,7 @@ do_uninstall() {
         echo "⚠ Could not remove $OLD_SYSTEM_PATH (may need sudo)" >&2
       fi
     fi
-  elif [ -e "$OLD_SYSTEM_PATH" ]; then
+  elif ! is_ci && [ -e "$OLD_SYSTEM_PATH" ]; then
     echo "⚠ Found existing non-symlink file at $OLD_SYSTEM_PATH; not removing automatically." >&2
   fi
 
@@ -508,4 +508,7 @@ else
   echo "  Then verify: ${BIN_DIR}/fvm --version"
   echo ""
   echo "  PATH: export PATH=\"$BIN_DIR:\$PATH\""
+  if is_ci; then
+    exit 1
+  fi
 fi