White list (#5)

Author: nvsdt

Tsarev.Analyzer.Hardcode.Email.Test/Tsarev.Analyzer.Hardcode.Email.Test.csproj

@@ -2,6 +2,7 @@
   <PropertyGroup>
     <TargetFramework>netcoreapp2.1</TargetFramework>
     <AssemblyTitle>Tsarev.Analyzer.Hardcode.Email.Test</AssemblyTitle>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="xunit" Version="2.4.1" />

Tsarev.Analyzer.Hardcode.Guid.Test/Tsarev.Analyzer.Hardcode.Guid.Test.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <TargetFramework>netcoreapp2.1</TargetFramework>
     <AssemblyTitle>Tsarev.Analyzer.Hardcode.Guid.Test</AssemblyTitle>
-   
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="11.0.0" />
@@ -13,5 +13,4 @@
     <ProjectReference Include="..\Tsarev.Analyzer.Hardcode.Guid\Tsarev.Analyzer.Hardcode.Guid.csproj" />
     <ProjectReference Include="..\Tsarev.Analyzer.TestHelpers\Tsarev.Analyzer.TestHelpers.csproj" />
   </ItemGroup>
-
 </Project>

Tsarev.Analyzer.Hardcode.Url/UrlHardcodeAnalyzer.cs

@@ -1,10 +1,11 @@
-using System.Collections.Immutable;
+using System;
+using System.Collections.Generic;
+using System.Collections.Immutable;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
 using System.Linq;
-using System.Globalization;
 using Tsarev.Analyzer.Helpers;
 
 namespace Tsarev.Analyzer.Hardcode.Url
@@ -34,6 +35,11 @@ public override void Initialize(AnalysisContext context)
     }
 
     private static readonly string[] BlackList = { "http:", "https:", "ftp:", "tcp:"};
+    
+    private static readonly string[] WhiteList =
+    {
+      "http://schemas.xmlsoap.org/"
+    };
 
     /// <summary>
     /// List of attributes that expected to contain URLs, and this is correct.
@@ -57,7 +63,15 @@ private static void AnalyzeLiteral(SyntaxNodeAnalysisContext context)
         return;
       }
 
-      CheckStringValue(context, context.Node.GetLiteralStringValueOrDefault());
+      var value = context.Node.GetLiteralStringValueOrDefault();
+      
+      foreach (var url in GetUrls(value))
+      {
+        if (!WhiteList.Any(x => url.StartsWith(x, StringComparison.InvariantCultureIgnoreCase)))
+        {
+          context.ReportDiagnostic(Diagnostic.Create(Rule, context.Node.GetLocation(), value));
+        }
+      }
     }
 
     private static bool IsArgumentOfWhiteListedAttribute(SyntaxNode node)
@@ -66,14 +80,50 @@ private static bool IsArgumentOfWhiteListedAttribute(SyntaxNode node)
       var attribute = argument?.WalkToAttribute();
       return attribute != null && AttributeNameWhiteList.Contains(attribute.GetAttributeName());
     }
+    
+    private static IEnumerable<string> GetUrls(string value)
+    {
+      var entries = new List<string>();
 
-    private static void CheckStringValue(SyntaxNodeAnalysisContext context, string value)
+      var indicesOfEntries = GetIndicesOfEntries(value, BlackList).ToArray();
+      for (var index = 0; index < indicesOfEntries.Length - 1; index++)
+      {
+        var entryStart = indicesOfEntries[index];
+        var entryFinish = indicesOfEntries[index + 1];
+        var entryLength = entryFinish - entryStart;
+        var entry = value.Substring(entryStart, entryLength);
+        entries.Add(entry);
+      }
+      entries.Add(value.Substring(indicesOfEntries[indicesOfEntries.Length - 1]));
+            
+      return entries;
+    }
+
+    private static IEnumerable<int> GetIndicesOfEntries(string value, IReadOnlyCollection<string> entries)
     {
-      var comparer = CultureInfo.InvariantCulture.CompareInfo;
-      if (BlackList.Any(part => comparer.IndexOf(value, part, CompareOptions.IgnoreCase) >= 0))
+      var offset = 0;
+      int indexOfEntry;
+      while ((indexOfEntry = IndexOfSomeEntry(value, entries, ref offset)) != - 1)
       {
-        context.ReportDiagnostic(Diagnostic.Create(Rule, context.Node.GetLocation(), value));
+        yield return indexOfEntry;
+      }
+    }
+        
+    private static int IndexOfSomeEntry(string value, IEnumerable<string> entries, ref int offset)
+    {
+      var indexOfSomeEntry = -1;
+      var lengthOfSomeEntry = 0;
+      foreach (var entry in entries)
+      {       
+        var indexOfEntry = value.IndexOf(entry, offset, StringComparison.InvariantCultureIgnoreCase);
+        if (indexOfEntry >= 0 && (indexOfEntry < indexOfSomeEntry || indexOfSomeEntry == -1))
+        {
+          indexOfSomeEntry = indexOfEntry;
+          lengthOfSomeEntry = entry.Length;
+        }
       }
+      offset = indexOfSomeEntry + lengthOfSomeEntry;
+      return indexOfSomeEntry;
     }
   }
 }

Tsarev.Analyzer.Web.Test/Tsarev.Analyzer.Web.Test.csproj

@@ -2,10 +2,9 @@
   <PropertyGroup>
     <TargetFramework>netcoreapp2.1</TargetFramework>
     <AssemblyTitle>Tsarev.AsyncControllerAnalyzer.Test</AssemblyTitle>
-    
     <Product>Tsarev.AsyncControllerAnalyzer.Test</Product>
+    <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
-  
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="11.0.0" />
     <PackageReference Include="xunit" Version="2.4.1" />

UrlHardcodeAnalyzer.Test/Tsarev.Analyzer.Hardcode.Url.Test.csproj

@@ -1,21 +1,16 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    
-   
     <TargetFramework>netcoreapp2.1</TargetFramework>
     <AssemblyTitle>VatHardcodeAnalyzer.Test</AssemblyTitle>
     <GenerateDocumentationFile>false</GenerateDocumentationFile>
   </PropertyGroup>
-
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="11.0.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />
-
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\Tsarev.Analyzer.TestHelpers\Tsarev.Analyzer.TestHelpers.csproj" />
     <ProjectReference Include="..\Tsarev.Analyzer.Hardcode.Url\Tsarev.Analyzer.Hardcode.Url.csproj" />
   </ItemGroup>
-
 </Project>

UrlHardcodeAnalyzer.Test/UrlHardcodeUnitTests.cs

@@ -1,3 +1,4 @@
+using System;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Diagnostics;
 using Tsarev.Analyzer.TestHelpers;
@@ -213,7 +214,72 @@ public void Method() {
 
       VerifyCSharpDiagnostic(test, ExpectUlrHardcode(6, 25, "http://example.com"));
     }
+    
+    [Fact]
+    public void TestClaimsString()
+    {
+      var test = @"
+    namespace ConsoleApplication1
+    {
+        class TypeName {
+        public void Method() {
+           var test = $""http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier"";
+        }
+      }
+    }";
 
+      VerifyCSharpDiagnostic(test);
+    }
+    
+    [Fact]
+    public void TestTwoClaimsString()
+    {
+      var test = @"
+    namespace ConsoleApplication1
+    {
+        class TypeName {
+        public void Method() {
+           var test = $""http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier"";
+        }
+      }
+    }";
+
+      VerifyCSharpDiagnostic(test);
+    }
+    
+    [Fact]
+    public void TestMultiHostWithWhiteListStart()
+    {
+      var test = @"
+    namespace ConsoleApplication1
+    {
+        class TypeName {
+        public void Method() {
+           var test = $""ftp://example.com http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier"";
+        }
+      }
+    }";
+
+      VerifyCSharpDiagnostic(test, ExpectUlrHardcode(6, 25, "ftp://example.com http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier"));
+    }
+    
+    [Fact]
+    public void TestMultiHostWithWhiteListEnd()
+    {
+      var test = @"
+    namespace ConsoleApplication1
+    {
+        class TypeName {
+        public void Method() {
+           var test = $""http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier ftp://example.com"";
+        }
+      }
+    }";
+
+      var x = test.Split(new[] {"http://", "TCP://"}, StringSplitOptions.None);
+      
+      VerifyCSharpDiagnostic(test, ExpectUlrHardcode(6, 25, "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier ftp://example.com"));
+    }
 
     protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer() => new UrlHardcodeAnalyzer();
   }