improve assertions in DiagnosticVerifier

leotsarev · leotsarev · commit fbc2c2e840db · 2018-03-30T15:33:36.000+03:00
diff --git a/Tsarev.Analyzer.TestHelpers/DiagnosticVerifier.cs b/Tsarev.Analyzer.TestHelpers/DiagnosticVerifier.cs
@@ -46,13 +46,13 @@ protected void VerifyCSharpDiagnostic(string sources, params DiagnosticResult[]
     private static void VerifyDiagnosticResults(IReadOnlyList<Diagnostic> actualResults, DiagnosticAnalyzer analyzer, params DiagnosticResult[] expectedResults)
     {
       var expectedCount = expectedResults.Length;
-      var actualCount = actualResults.Count;
+      var actualDiagnosticsCount = actualResults.Count;
 
-      if (expectedCount != actualCount)
+      if (expectedCount != actualDiagnosticsCount)
       {
         var diagnosticsOutput = actualResults.Any() ? FormatDiagnostics(analyzer, actualResults.ToArray()) : "    NONE.";
-        actualCount.ShouldBe(expectedCount, 
-          $"Mismatch between number of diagnostics returned, expected \"{expectedCount}\" actual \"{actualCount}\"\r\n\r\nDiagnostics:\r\n{diagnosticsOutput}\r\n");
+        actualDiagnosticsCount.ShouldBe(expectedCount, 
+          $"Diagnostics:\r\n{diagnosticsOutput}\r\n");
       }
 
       for (var i = 0; i < expectedResults.Length; i++)

Original file line number	Diff line number	Diff line change
`@@ -46,13 +46,13 @@ protected void VerifyCSharpDiagnostic(string sources, params DiagnosticResult[]`
`46`	`46`	`private static void VerifyDiagnosticResults(IReadOnlyList<Diagnostic> actualResults, DiagnosticAnalyzer analyzer, params DiagnosticResult[] expectedResults)`
`47`	`47`	`{`
`48`	`48`	`var expectedCount = expectedResults.Length;`
`49`		`- var actualCount = actualResults.Count;`
	`49`	`+ var actualDiagnosticsCount = actualResults.Count;`
`50`	`50`
`51`		`- if (expectedCount != actualCount)`
	`51`	`+ if (expectedCount != actualDiagnosticsCount)`
`52`	`52`	`{`
`53`	`53`	`var diagnosticsOutput = actualResults.Any() ? FormatDiagnostics(analyzer, actualResults.ToArray()) : " NONE.";`
`54`		`- actualCount.ShouldBe(expectedCount,`
`55`		`- $"Mismatch between number of diagnostics returned, expected \"{expectedCount}\" actual \"{actualCount}\"\r\n\r\nDiagnostics:\r\n{diagnosticsOutput}\r\n");`
	`54`	`+ actualDiagnosticsCount.ShouldBe(expectedCount,`
	`55`	`+ $"Diagnostics:\r\n{diagnosticsOutput}\r\n");`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`for (var i = 0; i < expectedResults.Length; i++)`