feat(pkg, nvidia): remove unused nvidia query func, flags for scan command (#669)

Signed-off-by: Gyuho Lee <[email protected]>

---------

Signed-off-by: Gyuho Lee <[email protected]>

Author: gyuho

README.md

@@ -72,10 +72,6 @@ You can also start with the standalone mode and later switch to the managed opti
 sudo gpud login --token <LEPTON_AI_TOKEN>
 ```
 
-To access the local web UI, open https://localhost:15132 in your browser.
-
-If run with `gpud up`, you may disable this local web UI by setting `FLAGS="--web-enable=false"` to the `/etc/default/gpud` environment file and restart the service.
-
 #### Run GPUd with Kubernetes
 
 See [gpud helm chart](./charts/gpud/README.md) to deploy GPUd in your Kubernetes cluster.

cmd/gpud/command/command.go

@@ -32,22 +32,12 @@ var (
 
 	retentionPeriod time.Duration
 
-	netcheck  bool
-	diskcheck bool
-	kmsgCheck bool
-
 	enableAutoUpdate   bool
 	autoUpdateExitCode int
 
-	kernelModulesToCheck cli.StringSlice
-
+	kernelModulesToCheck         cli.StringSlice
 	dockerIgnoreConnectionErrors bool
-
-	ibstatCommand string
-
-	checkInfiniBand bool
-
-	deprecatedWebEnable bool
+	ibstatCommand                string
 )
 
 const (
@@ -198,11 +188,6 @@ sudo rm /etc/systemd/system/gpud.service
 					Destination: &retentionPeriod,
 					Value:       config.DefaultRetentionPeriod.Duration,
 				},
-				&cli.BoolFlag{
-					Name:        "web-enable",
-					Usage:       "(DEPRECATED) enable local web interface",
-					Destination: &deprecatedWebEnable,
-				},
 				cli.StringFlag{
 					Name:  "endpoint",
 					Usage: "endpoint for control plane",
@@ -445,26 +430,6 @@ sudo rm /etc/systemd/system/gpud.service
 					Usage:       "set the logging level [debug, info, warn, error, fatal, panic, dpanic]",
 					Destination: &logLevel,
 				},
-				&cli.BoolTFlag{
-					Name:        "netcheck",
-					Usage:       "enable network connectivity checks to global edge/derp servers (default: true)",
-					Destination: &netcheck,
-				},
-				&cli.BoolTFlag{
-					Name:        "diskcheck",
-					Usage:       "enable disk checks (default: true)",
-					Destination: &diskcheck,
-				},
-				&cli.BoolTFlag{
-					Name:        "kmsg-check",
-					Usage:       "enable kmsg checks (default: true)",
-					Destination: &kmsgCheck,
-				},
-				&cli.BoolFlag{
-					Name:        "check-ib",
-					Usage:       "enable infiniband checks (default: false)",
-					Destination: &checkInfiniBand,
-				},
 
 				// only for testing
 				cli.StringFlag{

cmd/gpud/command/scan.go

@@ -19,11 +19,7 @@ func cmdScan(cliContext *cli.Context) error {
 	log.Logger = log.CreateLogger(zapLvl, logFile)
 
 	opts := []scan.OpOption{
-		scan.WithNetcheck(netcheck),
-		scan.WithDiskcheck(diskcheck),
-		scan.WithKMsgCheck(kmsgCheck),
 		scan.WithIbstatCommand(ibstatCommand),
-		scan.WithCheckInfiniband(checkInfiniBand),
 	}
 	if zapLvl.Level() <= zap.DebugLevel { // e.g., info, warn, error
 		opts = append(opts, scan.WithDebug(true))

e2e/e2e_test.go

@@ -62,7 +62,7 @@ var _ = Describe("[GPUD E2E]", Ordered, func() {
 		Expect(err).ToNot(HaveOccurred(), "failed to mock lspci")
 
 		By("start gpud scan")
-		cmd = exec.CommandContext(gCtx, os.Getenv("GPUD_BIN"), "scan", "--kmsg-check=false")
+		cmd = exec.CommandContext(gCtx, os.Getenv("GPUD_BIN"), "scan")
 		b, err := cmd.CombinedOutput()
 		Expect(err).NotTo(HaveOccurred(), fmt.Sprintf("failed to run gpud scan:\n%s", string(b)))
 		GinkgoLogr.Info("gpud scan successfully", "output", string(b))