appease linter

Author: lestrrat

http/http_example_test.go

@@ -25,7 +25,7 @@ func ExampleWrap() {
 	appHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
 		w.Header().Set("Date", "Mon, 01 Jan 2024 00:00:00 GMT") // Fixed date for testing
-		fmt.Fprint(w, `{"message": "Hello, signed world!"}`)
+		_, _ = fmt.Fprint(w, `{"message": "Hello, signed world!"}`)
 	})
 
 	// Create fixed clock for deterministic timestamps
@@ -87,7 +87,7 @@ func ExampleNewClient() {
 	// Create the application handler
 	appHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/json")
-		fmt.Fprint(w, `{"status": "success"}`)
+		_, _ = fmt.Fprint(w, `{"status": "success"}`)
 	})
 
 	// Wrap with just response signing for now (verification can be added separately)
@@ -115,7 +115,7 @@ func ExampleNewClient() {
 		fmt.Printf("Request failed: %v\n", err)
 		return
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	// Only print if something went wrong
 	if resp.StatusCode != http.StatusOK {

http/http_test.go

@@ -37,7 +37,7 @@ func testHandler(message string) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "text/plain")
 		w.WriteHeader(http.StatusOK)
-		fmt.Fprint(w, message)
+		_, _ = fmt.Fprint(w, message)
 	})
 }
 
@@ -139,7 +139,7 @@ func TestSigningTransport(t *testing.T) {
 			w.Header().Set("X-Signature", r.Header.Get("Signature"))
 			w.Header().Set("X-Signature-Input", r.Header.Get("Signature-Input"))
 			w.WriteHeader(http.StatusOK)
-			fmt.Fprint(w, "ok")
+			_, _ = fmt.Fprint(w, "ok")
 		}))
 		defer server.Close()
 
@@ -150,7 +150,7 @@ func TestSigningTransport(t *testing.T) {
 		// Make a request
 		resp, err := client.Get(server.URL + "/test")
 		require.NoError(t, err)
-		defer resp.Body.Close()
+		defer func() { _ = resp.Body.Close() }()
 
 		// Check that signature headers were added
 		require.NotEmpty(t, resp.Header.Get("X-Signature"))
@@ -241,7 +241,7 @@ func TestErrorHandling(t *testing.T) {
 	t.Run("Custom error handler", func(t *testing.T) {
 		customHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(http.StatusForbidden)
-			fmt.Fprint(w, "Custom error response")
+			_, _ = fmt.Fprint(w, "Custom error response")
 		})
 
 		verifier := htmsighttp.NewVerifier(&htmsighttp.StaticKeyResolver{Key: testPublicKey})

http/signer.go

@@ -178,11 +178,11 @@ func (w *signingResponseWriter) addSignatureHeaders() {
 	inputValue := input.NewValueBuilder().AddDefinition(def).MustBuild()
 
 	// Prepare context with response information
-	ctx := component.WithResponseInfo(context.Background(), w.ResponseWriter.Header(), w.statusCode,
+	ctx := component.WithResponseInfo(context.Background(), w.Header(), w.statusCode,
 		component.RequestInfoFromHTTP(w.request))
 
 	// Sign the response using the new SignResponse API
-	err := htmsig.SignResponse(ctx, w.ResponseWriter.Header(), inputValue, w.signer.Key)
+	err := htmsig.SignResponse(ctx, w.Header(), inputValue, w.signer.Key)
 	if err != nil {
 		// Handle signing error based on configuration
 		if w.signer.ErrorHandler != nil {

http/verifier.go

@@ -190,14 +190,6 @@ func DefaultErrorHandler() http.Handler {
 // VerifierOption configures a Verifier.
 type VerifierOption = option.Interface
 
-type verifierOption struct {
-	maxSignatureAge    *time.Duration
-	requiredComponents []component.Identifier
-	allowedAlgorithms  []string
-	skipOnMissing      *bool
-	errorHandler       http.Handler
-}
-
 // WithMaxSignatureAge configures maximum signature age for replay protection.
 func WithMaxSignatureAge(maxAge time.Duration) VerifierOption {
 	return option.New(identMaxSignatureAge{}, maxAge)