Expose per-channel black level corrections via user_cblack parameter#278
Merged
Expose per-channel black level corrections via user_cblack parameter#278
Conversation
Co-authored-by: letmaik <530988+letmaik@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for per-channel black level corrections
Expose per-channel black level corrections via user_cblack parameter
Jan 27, 2026
letmaik
reviewed
Jan 27, 2026
letmaik
reviewed
Jan 27, 2026
…entation Co-authored-by: letmaik <530988+letmaik@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
user_blackparameter applies a single black level to all channels, causing color casts when correcting low-value noise. libraw supports per-channel corrections viauser_cblack[4]but rawpy didn't expose it.Changes
user_cblackparameter toParams.__init__()accepting a 4-element list for [R, G, B, G2] channelsuser_cblack[4]array inapply_params()user_cblackvalues are offsets/corrections applied on top ofuser_blackuser_blackUsage
Key behavior:
user_cblackvalues are corrections/offsets applied on top of the baseuser_blackvalue, not absolute black levels. This allows setting a common base black level with per-channel fine-tuning.Pattern follows existing
user_wbparameter. Backward compatible - defaults to[0, 0, 0, 0]when not specified.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.