Remove Boulder's understanding of FAKECLOCK (#8356)

We no longer set the FAKECLOCK environment variable in any integration
tests, so remove the dead code which understood it.

Closes #4934

Author: aarongable

cmd/admin/admin.go

@@ -52,7 +52,7 @@ func newAdmin(configFile string, dryRun bool) (*admin, error) {
 	defer oTelShutdown(context.Background())
 	logger.Info(cmd.VersionString())
 
-	clk := cmd.Clock()
+	clk := clock.New()
 	features.Set(c.Admin.Features)
 
 	tlsConfig, err := c.Admin.TLS.Load(scope)

cmd/akamai-purger/main.go

@@ -12,6 +12,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/jmhodges/clock"
 	"github.com/prometheus/client_golang/prometheus"
 	"google.golang.org/protobuf/types/known/emptypb"
 
@@ -394,7 +395,7 @@ func manualPurge(purgeClient *akamai.CachePurgeClient, tag, tagFile string) {
 
 // daemon initializes the akamai-purger gRPC service.
 func daemon(c Config, ap *akamaiPurger, logger blog.Logger, scope prometheus.Registerer) {
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	tlsConfig, err := c.AkamaiPurger.TLS.Load(scope)
 	cmd.FailOnError(err, "tlsConfig config")

cmd/bad-key-revoker/main.go

@@ -327,7 +327,7 @@ func main() {
 	scope, logger, oTelShutdown := cmd.StatsAndLogging(config.Syslog, config.OpenTelemetry, config.BadKeyRevoker.DebugAddr)
 	defer oTelShutdown(context.Background())
 	logger.Info(cmd.VersionString())
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	scope.MustRegister(keysProcessed)
 	scope.MustRegister(certsRevoked)

cmd/boulder-ca/main.go

@@ -8,6 +8,8 @@ import (
 	"strconv"
 	"time"
 
+	"github.com/jmhodges/clock"
+
 	"github.com/letsencrypt/boulder/ca"
 	capb "github.com/letsencrypt/boulder/ca/proto"
 	"github.com/letsencrypt/boulder/cmd"
@@ -182,7 +184,7 @@ func main() {
 		cmd.FailOnError(err, "Failed to load CT Log List")
 	}
 
-	clk := cmd.Clock()
+	clk := clock.New()
 	var crlShards int
 	issuers := make([]*issuance.Issuer, 0, len(c.CA.Issuance.Issuers))
 	for i, issuerConfig := range c.CA.Issuance.Issuers {

cmd/boulder-publisher/main.go

@@ -8,6 +8,7 @@ import (
 	"runtime"
 
 	ct "github.com/google/certificate-transparency-go"
+	"github.com/jmhodges/clock"
 
 	"github.com/letsencrypt/boulder/cmd"
 	"github.com/letsencrypt/boulder/features"
@@ -88,7 +89,7 @@ func main() {
 	tlsConfig, err := c.Publisher.TLS.Load(scope)
 	cmd.FailOnError(err, "TLS config")
 
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	pubi := publisher.New(bundles, c.Publisher.UserAgent, logger, scope)
 

cmd/boulder-ra/main.go

@@ -5,6 +5,8 @@ import (
 	"flag"
 	"os"
 
+	"github.com/jmhodges/clock"
+
 	akamaipb "github.com/letsencrypt/boulder/akamai/proto"
 	capb "github.com/letsencrypt/boulder/ca/proto"
 	"github.com/letsencrypt/boulder/cmd"
@@ -184,7 +186,7 @@ func main() {
 	tlsConfig, err := c.RA.TLS.Load(scope)
 	cmd.FailOnError(err, "TLS config")
 
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	vaConn, err := bgrpc.ClientSetup(c.RA.VAService, tlsConfig, scope, clk)
 	cmd.FailOnError(err, "Unable to create VA client")

cmd/boulder-sa/main.go

@@ -5,6 +5,8 @@ import (
 	"flag"
 	"os"
 
+	"github.com/jmhodges/clock"
+
 	"github.com/letsencrypt/boulder/cmd"
 	"github.com/letsencrypt/boulder/config"
 	"github.com/letsencrypt/boulder/features"
@@ -75,7 +77,7 @@ func main() {
 		cmd.FailOnError(err, "While initializing dbIncidentsMap")
 	}
 
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	parallel := c.SA.ParallelismPerRPC
 	if parallel < 1 {

cmd/boulder-va/main.go

@@ -6,6 +6,8 @@ import (
 	"os"
 	"time"
 
+	"github.com/jmhodges/clock"
+
 	"github.com/letsencrypt/boulder/bdns"
 	"github.com/letsencrypt/boulder/cmd"
 	"github.com/letsencrypt/boulder/features"
@@ -78,7 +80,7 @@ func main() {
 	scope, logger, oTelShutdown := cmd.StatsAndLogging(c.Syslog, c.OpenTelemetry, c.VA.DebugAddr)
 	defer oTelShutdown(context.Background())
 	logger.Info(cmd.VersionString())
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	var servers bdns.ServerProvider
 

cmd/boulder-wfe2/main.go

@@ -10,6 +10,8 @@ import (
 	"os"
 	"time"
 
+	"github.com/jmhodges/clock"
+
 	"github.com/letsencrypt/boulder/cmd"
 	"github.com/letsencrypt/boulder/config"
 	emailpb "github.com/letsencrypt/boulder/email/proto"
@@ -261,7 +263,7 @@ func main() {
 	stats, logger, oTelShutdown := cmd.StatsAndLogging(c.Syslog, c.OpenTelemetry, c.WFE.DebugAddr)
 	logger.Info(cmd.VersionString())
 
-	clk := cmd.Clock()
+	clk := clock.New()
 
 	var unpauseSigner unpause.JWTSigner
 	if features.Get().CheckIdentifiersPaused {

cmd/cert-checker/main.go

@@ -630,7 +630,7 @@ func main() {
 
 	checker := newChecker(
 		saDbMap,
-		cmd.Clock(),
+		clock.New(),
 		pa,
 		kp,
 		config.CertChecker.CheckPeriod.Duration,