Re-enable wastedassign linter (#7788)

aarongable · web-flow · commit 46fc4c25ab86 · 2024-11-05T07:45:37.000-08:00
Fixes #6202
diff --git a/.golangci.yml b/.golangci.yml
@@ -12,7 +12,7 @@ linters:
     - unconvert
     - unparam
     - unused
-    # TODO(#6202): Re-enable 'wastedassign' linter
+    - wastedassign
 linters-settings:
   errcheck:
     exclude-functions:
diff --git a/crl/updater/updater_test.go b/crl/updater/updater_test.go
@@ -396,6 +396,6 @@ func TestGetChunkAtTime(t *testing.T) {
 	// the time twice, since the whole point of "very far in the future" is that
 	// it isn't representable by a time.Duration.
 	atTime = anchorTime().Add(200 * 365 * 24 * time.Hour).Add(200 * 365 * 24 * time.Hour)
-	c, err = GetChunkAtTime(shardWidth, numShards, atTime)
+	_, err = GetChunkAtTime(shardWidth, numShards, atTime)
 	test.AssertError(t, err, "getting far-future chunk")
 }

Original file line number	Diff line number	Diff line change
`@@ -396,6 +396,6 @@ func TestGetChunkAtTime(t *testing.T) {`
`396`	`396`	`// the time twice, since the whole point of "very far in the future" is that`
`397`	`397`	`// it isn't representable by a time.Duration.`
`398`	`398`	`atTime = anchorTime().Add(200 * 365 * 24 * time.Hour).Add(200 * 365 * 24 * time.Hour)`
`399`		`- c, err = GetChunkAtTime(shardWidth, numShards, atTime)`
	`399`	`+ _, err = GetChunkAtTime(shardWidth, numShards, atTime)`
`400`	`400`	`test.AssertError(t, err, "getting far-future chunk")`
`401`	`401`	`}`