Simplify prepChallengeForDisplay

Author: aarongable

core/objects.go

@@ -144,7 +144,7 @@ type ValidationRecord struct {
 	// ResolverAddrs is the host:port of the DNS resolver(s) that fulfilled the
 	// lookup for AddressUsed. During recursive A and AAAA lookups, a record may
 	// instead look like A:host:port or AAAA:host:port
-	ResolverAddrs []string `json:"resolverAddrs,omitempty"`
+	ResolverAddrs []string `json:"-"`
 }
 
 // Challenge is an aggregate of all data needed for any challenges.

wfe2/wfe.go

@@ -1217,11 +1217,6 @@ func (wfe *WebFrontEndImpl) prepChallengeForDisplay(
 	if authz.Status == core.StatusInvalid {
 		challenge.Status = authz.Status
 	}
-
-	// This field is not useful for the client, only internal debugging,
-	for idx := range challenge.ValidationRecord {
-		challenge.ValidationRecord[idx].ResolverAddrs = nil
-	}
 }
 
 // prepAuthorizationForDisplay takes a core.Authorization and prepares it for