Skip to content

Commit 513e113

Browse files
authored
CA: delete GenerateOCSP method (#8351)
Remove the CA.GenerateOCSP method, and all code related to signing OCSP responses. Fixes #8349
1 parent 50224d2 commit 513e113

File tree

12 files changed

+75
-908
lines changed

12 files changed

+75
-908
lines changed

ca/ca.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import (
2727
"go.opentelemetry.io/otel/trace"
2828
"golang.org/x/crypto/cryptobyte"
2929
cryptobyte_asn1 "golang.org/x/crypto/cryptobyte/asn1"
30-
"golang.org/x/crypto/ocsp"
3130
"google.golang.org/protobuf/types/known/timestamppb"
3231

3332
capb "github.com/letsencrypt/boulder/ca/proto"
@@ -259,12 +258,6 @@ func NewCertificateAuthorityImpl(
259258
return ca, nil
260259
}
261260

262-
var ocspStatusToCode = map[string]int{
263-
"good": ocsp.Good,
264-
"revoked": ocsp.Revoked,
265-
"unknown": ocsp.Unknown,
266-
}
267-
268261
// issuePrecertificate is the first step in the [issuance cycle]. It allocates and stores a serial number,
269262
// selects a certificate profile, generates and stores a linting certificate, sets the serial's status to
270263
// "wait", signs and stores a precertificate, updates the serial's status to "good", then returns the

ca/ca_test.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import (
3636
"github.com/letsencrypt/boulder/identifier"
3737
"github.com/letsencrypt/boulder/issuance"
3838
blog "github.com/letsencrypt/boulder/log"
39-
"github.com/letsencrypt/boulder/metrics"
4039
"github.com/letsencrypt/boulder/must"
4140
"github.com/letsencrypt/boulder/policy"
4241
rapb "github.com/letsencrypt/boulder/ra/proto"
@@ -100,7 +99,6 @@ func mustRead(path string) []byte {
10099

101100
type testCtx struct {
102101
pa core.PolicyAuthority
103-
ocsp *ocspImpl
104102
crl *crlImpl
105103
certProfiles map[string]*issuance.ProfileConfig
106104
serialPrefix byte
@@ -213,18 +211,6 @@ func setup(t *testing.T) *testCtx {
213211
}, []string{"profile"})
214212
cametrics := &caMetrics{signatureCount, signErrorCount, lintErrorCount, certificatesCount}
215213

216-
ocsp, err := NewOCSPImpl(
217-
boulderIssuers,
218-
24*time.Hour,
219-
0,
220-
time.Second,
221-
blog.NewMock(),
222-
metrics.NoopRegisterer,
223-
cametrics,
224-
fc,
225-
)
226-
test.AssertNotError(t, err, "Failed to create ocsp impl")
227-
228214
crl, err := NewCRLImpl(
229215
boulderIssuers,
230216
issuance.CRLProfileConfig{
@@ -239,7 +225,6 @@ func setup(t *testing.T) *testCtx {
239225

240226
return &testCtx{
241227
pa: pa,
242-
ocsp: ocsp,
243228
crl: crl,
244229
certProfiles: certProfiles,
245230
serialPrefix: 0x11,

ca/ocsp.go

Lines changed: 0 additions & 253 deletions
This file was deleted.

0 commit comments

Comments
 (0)