Skip to content

Commit 668017a

Browse files
authored
Update CI to go1.25.2 (#8436)
The go1.25.2 security release addresses a number of CVEs, including ones affecting crypto/x509, crypto/tls, encoding/asn1, and other packages we rely on. See the full details here: - https://go.dev/doc/devel/release#go1.25.2 - https://groups.google.com/g/golang-announce/c/4Emdl2iQ_bI Also make two small updates to accommodate the new version of `typos` pulled in by the new boulder-tools image, and the new version of net/url which closes off a corner case we were testing.
1 parent 36f7723 commit 668017a

File tree

7 files changed

+8
-15
lines changed

7 files changed

+8
-15
lines changed

.github/workflows/boulder-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
matrix:
3737
# Add additional docker image tags here and all tests will be run with the additional image.
3838
BOULDER_TOOLS_TAG:
39-
- go1.25.0_2025-08-15
39+
- go1.25.2_2025-10-07
4040
# Tests command definitions. Use the entire "docker compose" command you want to run.
4141
tests:
4242
# Run ./test.sh --help for a description of each of the flags.
@@ -122,7 +122,7 @@ jobs:
122122
# When set to true, GitHub cancels all in-progress jobs if any matrix job fails. Default: true
123123
fail-fast: false
124124
matrix:
125-
go-version: [ '1.25.0' ]
125+
go-version: [ '1.25.2' ]
126126

127127
steps:
128128
# Checks out your repository under $GITHUB_WORKSPACE, so your job can access it

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
GO_VERSION:
18-
- "1.25.0"
18+
- "1.25.2"
1919
runs-on: ubuntu-24.04
2020
permissions:
2121
contents: write

.github/workflows/try-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
GO_VERSION:
22-
- "1.25.0"
22+
- "1.25.2"
2323
runs-on: ubuntu-24.04
2424
steps:
2525
- uses: actions/checkout@v4

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ services:
88
context: test/boulder-tools/
99
# Should match one of the GO_CI_VERSIONS in test/boulder-tools/tag_and_upload.sh.
1010
args:
11-
GO_VERSION: 1.25.0
11+
GO_VERSION: 1.25.2
1212
environment:
1313
# To solve HTTP-01 and TLS-ALPN-01 challenges, change the IP in FAKE_DNS
1414
# to the IP address where your ACME client's solver is listening. This is

precert/corr.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ func (e *extensionParser) Next() (cryptobyte.String, error) {
148148

149149
// unwrapExtensions takes a given a sequence of bytes representing the `extensions` field
150150
// of a TBSCertificate and parses away the outermost two layers, returning the inner bytes
151-
// of the Extensions SEQUENCE.
151+
// of the Extensions sequence.
152152
//
153153
// https://datatracker.ietf.org/doc/html/rfc5280#page-117
154154
//
@@ -193,7 +193,7 @@ func readIdenticalElement(a, b *cryptobyte.String) error {
193193
}
194194

195195
// tbsDERFromCertDER takes a Certificate object encoded as DER, and parses
196-
// away the outermost two SEQUENCEs to get the inner bytes of the TBSCertificate.
196+
// away the outermost two sequences to get the inner bytes of the TBSCertificate.
197197
//
198198
// https://datatracker.ietf.org/doc/html/rfc5280#page-116
199199
//

test/boulder-tools/tag_and_upload.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ DOCKER_REPO="letsencrypt/boulder-tools"
1212
# .github/workflows/release.yml,
1313
# .github/workflows/try-release.yml if appropriate,
1414
# and .github/workflows/boulder-ci.yml with the new container tag.
15-
GO_CI_VERSIONS=( "1.25.0" )
15+
GO_CI_VERSIONS=( "1.25.2" )
1616

1717
echo "Please login to allow push to DockerHub"
1818
docker login

va/http_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -273,13 +273,6 @@ func TestExtractRequestTarget(t *testing.T) {
273273
},
274274
ExpectedError: errors.New("Invalid host in redirect target, must end in IANA registered TLD"),
275275
},
276-
{
277-
Name: "malformed too-long IPv6 address",
278-
Req: &http.Request{
279-
URL: mustURL("https://[a:b:c:d:e:f:b:a:d]"),
280-
},
281-
ExpectedError: errors.New("Invalid host in redirect target, must end in IANA registered TLD"),
282-
},
283276
{
284277
Name: "bare IPv4, implicit port",
285278
Req: &http.Request{

0 commit comments

Comments
 (0)