Skip to content

Commit 6a75950

Browse files
authored
test: use SIGKILL instead of SIGTERM (#8612)
Now that we audit log clean shutdowns, it's very hard to find error messages among the logspam during shutdown. SIGKILL prevents the processes from logging anything on their way down.
1 parent 2c551e0 commit 6a75950

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/startservers.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -307,13 +307,12 @@ def stopChallSrv():
307307

308308
@atexit.register
309309
def stop():
310-
# When we are about to exit, send SIGTERM to each subprocess and wait for
311-
# them to nicely die. This reflects the restart process in prod and allows
312-
# us to exercise the graceful shutdown code paths.
310+
# When we are about to exit, send SIGKILL to each subprocess and wait for
311+
# them to die.
313312
global processes
314313
for p in reversed(processes):
315314
if p.poll() is None:
316-
p.send_signal(signal.SIGTERM)
315+
p.send_signal(signal.SIGKILL)
317316
p.wait()
318317
processes = []
319318

0 commit comments

Comments
 (0)